search

Magestore / Bannerslider-Magento2

Banner Slider Extension on Magento 2 - best way to capture the eyes of visitors!
http://www.magestore.com/banner-slider-on-magento2.html/
82 stars 100 forks source link

Magento 2.2 error di:compilation #101

Open cbrouard opened 6 years ago

cbrouard commented 6 years ago

Hello,

You have bug pending di compilation in new version Magento 2.2 into class Magestore\Bannerslider\Model\ResourceModel\Banner\Collection.

$ php bin/magento setup:di:compile Compilation was started. Interception cache generation... 6/7 [========================>---] 85% 2 mins 248.0 MiBErrors during compilation: Magestore\Bannerslider\Model\ResourceModel\Banner\Collection Incompatible argument type: Required type: \Magento\Framework\DB\Adapter\AdapterInterface. Actual type: \Magento\Framework\Model\ResourceModel\Db\AbstractDb; File: /var/www/eboutique.ponant.tbd/vendor/magestore/module-bannerslider/Model/ResourceModel/Banner/Collection.php

cbrouard commented 6 years ago

The fix : Replace into vendor/magestore/module-bannerslider/Model/ResourceModel/Banner/Collection.php:80 with \Magento\Framework\DB\Adapter\AdapterInterface $connection = null,

Thanks

maschwa88 commented 6 years ago

Thank you cbrouard, works! But in my case to be more precise: i had to delete the line before with $connection = null, and then add \Magento\Framework\DB\Adapter\AdapterInterface $connection = null without the , at the end.

dudzio12 commented 6 years ago

@edenduong - maybe it is the time to merge all the fixes into new build? You have everything...