search

Magestore / Bannerslider-Magento2

Banner Slider Extension on Magento 2 - best way to capture the eyes of visitors!
http://www.magestore.com/banner-slider-on-magento2.html/
82 stars 100 forks source link

"Manage Banner" section pointing to BannerSlider #56

Open rivaldoleon opened 8 years ago

rivaldoleon commented 8 years ago

After a fresh install of the 1.7 version, I was able to create a new slider, but when a hit the "Manage Banner" I'm getting some errors. I've created a Bannerslider folder, but some sections of the code are referencing BannerSlider. I've just replaced all those entries with Bannerslider, and now works perfectly.

friizu commented 8 years ago

Yes this was the issue, also fixes this: https://github.com/Magestore/Bannerslider-Magento2/issues/54

friizu commented 8 years ago

List of files i replaced "BannerSlider" to "Bannerslider" (cause namespaces and class names are case sensitive), after replacements all works like a charm. Tested on version 2.1.1

Controller/Adminhtml/AbstractAction.php Controller/Adminhtml/Banner/MassDelete.php Controller/Adminhtml/Banner/MassDisable.php Controller/Adminhtml/Banner/MassEnable.php Controller/Adminhtml/Slider/MassDelete.php Controller/Adminhtml/Slider/MassDisable.php Controller/Adminhtml/Slider/MassEnable.php Model/Data/Option/OptionHashInterface.php Model/ResourceModel/Banner/Collection.php Model/ResourceModel/Banner/Grid/Collection.php Model/ResourceModel/Banner/Grid/StatusesArray.php Model/ResourceModel/Report.php Model/ResourceModel/Report/Grid/Collection.php Model/ResourceModel/Slider/Grid/Collection.php Ui/Component/Listing/Column/AbstractColumn.php Ui/Component/Listing/Column/BannerstatusActions.php Ui/Component/Listing/Column/Image.php Ui/Component/Listing/Column/Slider.php etc/di.xml view/adminhtml/ui_component/banner_grid_listing.xml

sgrspkt commented 8 years ago

@friizu If i have my vendormodule name as Magestore Bannerslider, why do i change Bannerslider to BannerSlider ? The namespace depends on vendor_module name given on directory, right ?

friizu commented 8 years ago

You are right, don't! I replaced "BannerSlider" to "Bannerslider" not other way around.

sgrspkt commented 8 years ago

@friizu if i have vendor_module name as Magestore_Bannerslider and namespaces as Bannerslider, the error is same, how can i solve the problem ??

friizu commented 8 years ago

@sgrspkt - as on first post this thread and my previous post, you need to check all files I listed, for example: Controller/Adminhtml/AbstractAction.php line 173 you find:

$collection = $this->_objectManager->create('Magestore\BannerSlider\Model\ResourceModel\Banner\Collection');

You see path BannerSlider (what needs to be Bannerslider) and so on ... so you need to make replace to all those files to make this module work fluent.

ps. if u wanna make mass replace on those files be sure that you'r replace is case sensitive!

sgrspkt commented 8 years ago

@friizu, Thank you. I solved the problem of manage banner after replacing 'BannerSlider' with 'Bannerslider'.

marcatos commented 7 years ago

@sgrspkt here https://github.com/Magestore/Bannerslider-Magento2/issues/66#issuecomment-273444989 you can find our implementation

Vikram0811 commented 6 years ago

@friizu your solution worked for me. Thanks