search

Magestore / Bannerslider-Magento2

Banner Slider Extension on Magento 2 - best way to capture the eyes of visitors!
http://www.magestore.com/banner-slider-on-magento2.html/
82 stars 100 forks source link

miss spelling of "Bannerslider" #66

Open ziong opened 8 years ago

ziong commented 8 years ago

Some files are miss spell "Bannerslider" to "BannerSlider" As you can probably guess, this will lead errors in case-sensitive OS, e.g. Linux

Sachin-Suresh commented 8 years ago

Manage Banners link is not working in Linux after correcting spell "Bannerslider" to "BannerSlider"..it shows blank page without any error!...anybody faced similar issue?

ziong commented 8 years ago

Confirmed that it works for me. @Sachin-Suresh may need to check the apache error log for details. Actually I need to reinstall the "Bannerslider" to make it work.

marcatos commented 7 years ago

@ziong we standardized the naming convenction in our fork https://github.com/Hevelop/Bannerslider-Magento2/commit/50218103734272c2e8e7bf0830961491e599615a

caopaolo commented 7 years ago

You can change all word from BannerSlider to Bannerslider in all project (file name, interface, di, ui_component ...). This version work normally in window.

Vikram0811 commented 6 years ago

Hi @marcatos, Changing BannerSlider to Bannerslider does not work flawless though out the module access. Do you mean one should replace the complete module with this one - https://github.com/Hevelop/Bannerslider-Magento2/

Kindly help and suggest. Thanks.