MagiCircles / BanGDream

Bandori Party - The BanG Dream! Girls Band Party Database & Community
http://bandori.party/
61 stars 7 forks source link

Event/Gacha Custom View Glitch #146

Open LatidoReMe opened 6 years ago

LatidoReMe commented 6 years ago

When viewing the full page of an event/gacha, there are suppose to be those triangles to help indicate that you can open/close information for each version. However, a pop-up of an event/gacha when on another event/gacha's full page will be missing the triangles image Also, there seems to be a duplication glitch happening too. When you exit out of the pop-up on the page, the triangles will be generated again alongside the original triangles, allowing stuff like this to occur: image Note: This is an extreme example where I went in and out 4 times. It only generates one extra one at a time

Since users mainly use the pop-up view it ain't the highest of priorities, but it still should be fixed.

LatidoReMe commented 5 years ago

Extra Note on this: It still happens even with the new look. image It also seems to be shrinking both the event banner AND the gacha banner on the event page, which is interesting since the gacha doesn't have any need to be shrunk image

db0company commented 5 years ago

I figured out why it's happening. It's because it's the same function that's called when you load a gacha and an event, so when you open a gacha popup from an event (or event popup from gacha), it's called again. If you keep opening/closing the popup it will keep adding more.

I'm not sure how to fix yet, but at least I know where to look for.

@LatidoReMe The reason why it's resizing the images below them is because it's a table. The lines between the rows and columns of the table are invisible but they're still there. So when more text gets added to the "Japanese version" column, it's reducing the column on the right and all the rows get affected and become smaller as well.

Edit: I added lines to show you what happens:

screen shot 2018-10-03 at 12 29 28 pm screen shot 2018-10-03 at 12 29 40 pm