violet-r
commented
5 years ago I would also like birthday banners to be the correct size as everything else on the carousel. Currently, they are smaller and create a fluctuation in size. It's not a big deal, but it upsets my core.
Currently on BanPa, we have birthday banners that generate about 12 days before their birthday.
While everything works, I noticed that Himari's banner was in front of Rinko's, even though her birthday was later. Since Rinko's birthday is coming up sooner, it'd make more sense for her to be up front since her date is closer.
I believe the way to do this is simple too! In this section: https://github.com/MagiCircles/BanGDream/blob/426ae2d5739b88113087b1160b07209e7f86db45/bang/management/commands/generate_settings.py#L28-L30 you just need to add something like:
.order_by('birthday')One more thing I wanted to suggest was adding logic so that the trained forms of cards can be used for birthday banners too! Currently it is only taking into account the untrained art, as shown here: https://github.com/MagiCircles/BanGDream/blob/426ae2d5739b88113087b1160b07209e7f86db45/bang/management/commands/generate_settings.py#L43
If you modified the above and this: https://github.com/MagiCircles/BanGDream/blob/426ae2d5739b88113087b1160b07209e7f86db45/bang/management/commands/generate_settings.py#L31 you should be able to get it to allow the trained cards to be used too! Whether it's preferred or only used as a backup for when a card's untrained art doesn't work is unimportant to me, but I think people generally like seeing the newer cards, so it might help with that.