MagicForrest / DGVMTools

R package for processing, analysing and visualising ouput from Dynamic Global Vegetation Models (DGVMs)
GNU General Public License v3.0
26 stars 22 forks source link

Smith 2014 biomization #63

Closed lukasbaumbach closed 3 years ago

lukasbaumbach commented 3 years ago

Hi Matt!

I looked at your biome classification (had to translate it to Python for my purposes) and noticed a few discrepancies between your code and Smith's (2014) scheme. For example Smith uses maximum LAI of the growing season for all LAI references, whereas - at least as I understood - your code uses the average yearly LPJ-GUESS output "lai.out" for that. This could be particularly important for seasonal forest, where LAI fluctuations are high throughout the year (better use "mlai.out" and average the maxima of each year?). Additionally some thresholds seemed to be different (although your version is clearer than Smith on that):

Just wondering if there where errata in Smith or typos in DGVMTools. Best, Lukas

MagicForrest commented 3 years ago

Hi Lukas,

On your first point, don't worry, lai.out is the maximum over the year. As for the differences.

And anything else left over the just classify as desert (which makes the existing) desert criteria redundant, but anyways...

It is a tricky thing, since the script and the table in the paper don't quite add up. I was confused before. But now I think I will follow the script exactly and maybe just make a note in DGVMTools.

Cheers,

M@

MagicForrest commented 3 years ago

Alright, implemented in the bugfix and dev branches. And the plots are nicer, thanks for bringing it to my attention. I'll close this now.

lukasbaumbach commented 3 years ago

Thanks for clarifying! Now that I saw the original script, indeed there are some differences to the paper (e.g. the script also applies > 0.8 for temperate biomes). Anyways, at least your version is consistent now :)