search

MagicJinn / Block-Sponsor-Comments

A browser extension that removes a preset list of video sponsors from youtube video descriptions and comments.
GNU General Public License v3.0
9 stars 3 forks source link

style(strings.json): sorted a-z #19

Closed olivertzeng closed 3 months ago

olivertzeng commented 3 months ago

and also added some strings

MagicJinn commented 3 months ago

The strings are currently sorted in 3 categories, and this is intentional. There is general (things like "Sponsored by"), groups, which are multiple strings all referring to the same sponsor, and single strings. It might be handy to sort the single strings alphabetically, but not the entirety of the file.

You are welcome to submit the sponsors you added in this in a separate pull request or github issue. I did see you added paypal, which is a bit too generic, as there are genuine reasons for people to include the word paypal in their description or comments (for example, donations), so we can't add that one.

olivertzeng commented 3 months ago

Isn’t donations self-promotion?Or sth like kofi?I also added floatplaneAnd other Chinese words Sent from Proton Mail for iOS 於 週四, 8月 1, 2024 時間 02:01, MagicJinn @.***> 寫道： The strings are currently sorted in 3 categories, and this is intentional. There is general (things like "Sponsored by"), groups, which are multiple strings all referring to the same sponsor, and single strings. It might be handy to sort the single strings alphabetically, but not the entirety of the file. You are welcome to submit the sponsors you added in this in a separate pull request or github issue. I did see you added paypal, which is a bit too generic, as there are genuine reasons for people to include the word paypal in their description or comments (for example, donations), so we can't add that one.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

olivertzeng commented 3 months ago

I will “unsort” these stuff and make them sta6 as is Sent from Proton Mail for iOS 於 週四, 8月 1, 2024 時間 02:01, MagicJinn @.***> 寫道： The strings are currently sorted in 3 categories, and this is intentional. There is general (things like "Sponsored by"), groups, which are multiple strings all referring to the same sponsor, and single strings. It might be handy to sort the single strings alphabetically, but not the entirety of the file. You are welcome to submit the sponsors you added in this in a separate pull request or github issue. I did see you added paypal, which is a bit too generic, as there are genuine reasons for people to include the word paypal in their description or comments (for example, donations), so we can't add that one.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>