MagicJinn / MrBeastify-Youtube

Is your browser experience boring? This extension adds the famous youtuber MrBeast to every thumbnail.
GNU General Public License v3.0
208 stars 90 forks source link

Doesn't work on Firefox 114.0.2 #8

Closed AutumnRivers closed 1 year ago

AutumnRivers commented 1 year ago

Doesn't seem to work on the latest stable build of Firefox for Windows. Originally thought it was because it was incompatible with Enhancer for YouTube, but disabling that extension does not make this work.

Screenshots show YouTube front page with Enhancer enabled and disabled, both with MrBeastify enabled. Enhancer Enabled Enhancer Disabled

Restarting the browser does not help, reloading the page does not help. Judging by other reviews, this seems to work for others. Unsure of why it's not working for me.

MagicJinn commented 1 year ago

Could you open the console to show me the console output? The console can be opened with ctrl + shift + i and clicking the console tab. Either provide a screenshot, or rightclick the console and press "Copy all messages" and share that!

AutumnRivers commented 1 year ago
SyntaxError: redeclaration of let Presence devHelper.js:1:1
performance.now precision has been modified for compatibility reasons. See https://bugzilla.mozilla.org/show_bug.cgi?id=1756970 for details. bug1803976-www.youtube.com-performance-now-precision.js:14:9
LegacyDataMixin will be applied to all legacy elements.
Set `_legacyUndefinedCheck: true` on element class to enable. desktop_polymer_enable_wil_icons.js:4310:9
Some cookies are misusing the recommended “SameSite“ attribute 54
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://googleads.g.doubleclick.net/pagead/id. (Reason: CORS request did not succeed). Status code: (null).
MrBeastify Loaded Successfully mrbeastify.js:78:9
TypeError: NetworkError when attempting to fetch resource. mrbeastify.js:53:10
Will-change memory consumption is too high. Budget limit is the document surface area multiplied by 3 (1338240 px). Occurrences of will-change over the budget will be ignored. www.youtube.com
DataCloneError: URL object could not be cloned. get-iframes.js:9
Loading failed for the <script> with source “https://static.doubleclick.net/instream/ad_status.js”. www.youtube.com:1:1
MouseEvent.mozPressure is deprecated. Use PointerEvent.pressure instead. desktop_polymer_enable_wil_icons.js:1974:45
The resource at “https://i.ytimg.com/generate_204” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. www.youtube.com
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://play.google.com/log?format=json&hasfast=true&authuser=0. (Reason: CORS request did not succeed). Status code: (null).
MagicJinn commented 1 year ago

That is really strange. Everything looks completely normal to me. The NetworkError produced by the addon is by design (but will be "fixed" in future versions) but otherwise this all looks good. I don't suppose you know what extension desktop_polymer_enable_wil_icons.js originates from? it originates from youtube. I really don't have a clue on this one.

MagicJinn commented 1 year ago

Something I've just noticed about the screenshots you've provided is that there are no video time indicators on any video. Is this a feature you deliberately removed? It seems to suggest something is layered on top of the thumbnails.

Could you perhaps open your console and type this line document.querySelectorAll('img[style^="position: absolute; top: 0px; left: 0px; width: 100%; height: 100%; z-index: 0;"]'); in there and return your output?

AutumnRivers commented 1 year ago
NodeList(20) [ img, img, img, img, img, img, img, img, img, img, … ]
0: <img src="moz-extension://180aa342…ba00e3ec3/images/20.png" style="position: absolute; top:… transform: scaleX(-1);">
1: <img src="moz-extension://180aa342…ba00e3ec3/images/18.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
2: <img src="moz-extension://180aa342…ba00e3ec3/images/29.png" style="position: absolute; top:… transform: scaleX(-1);">
3: <img src="moz-extension://180aa342…ba00e3ec3/images/27.png" style="position: absolute; top:… transform: scaleX(-1);">
4: <img src="moz-extension://180aa342…ba00e3ec3/images/24.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
5: <img src="moz-extension://180aa342…ba00e3ec3/images/28.png" style="position: absolute; top:… transform: scaleX(-1);">
6: <img src="moz-extension://180aa342…ba00e3ec3/images/10.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
7: <img src="moz-extension://180aa342…ba00e3ec3/images/18.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
8: <img src="moz-extension://180aa342…ba00e3ec3/images/27.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
9: <img src="moz-extension://180aa342…cba00e3ec3/images/2.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
10: <img src="moz-extension://180aa342…ba00e3ec3/images/10.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
11: <img src="moz-extension://180aa342…ba00e3ec3/images/21.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
12: <img src="moz-extension://180aa342…ba00e3ec3/images/27.png" style="position: absolute; top:… transform: scaleX(-1);">
13: <img src="moz-extension://180aa342…ba00e3ec3/images/31.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
14: <img src="moz-extension://180aa342…ba00e3ec3/images/15.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
15: <img src="moz-extension://180aa342…ba00e3ec3/images/28.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
16: <img src="moz-extension://180aa342…cba00e3ec3/images/9.png" style="position: absolute; top:… transform: scaleX(-1);">
17: <img src="moz-extension://180aa342…ba00e3ec3/images/23.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
18: <img src="moz-extension://180aa342…cba00e3ec3/images/5.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
19: <img src="moz-extension://180aa342…ba00e3ec3/images/25.png" style="position: absolute; top:…ight: 100%; z-index: 0;">
length: 20
<prototype>: NodeListPrototype { item: item(), keys: keys(), values: values(), … }

I should note that the time indicators do appear after a few seconds, that's an issue I've always had with Firefox.

AutumnRivers commented 1 year ago

Ah, nevermind, I've figured it out. DeArrow causes this to not work even when disabled within the extension menu. It has to be disabled from Firefox itself. Seems kinda invasive on their part, but good to know, I guess