search

MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.75k stars 4.2k forks source link

update the magicmirror package in the npm registry #2876

Open davide125 opened 2 years ago

davide125 commented 2 years ago

npm has a magicmirror package, but it's a very old version (2.0.0): https://www.npmjs.com/package/magicmirror . In spite of this, it seems to be actively used and downloaded (22 times in the last 7 days according to the stats). Please consider updating the npm package to the latest tagged version (and ideally keeping it up to date in the future). Thanks!

rejas commented 2 years ago

Is that a usecase at all: installing MM via npm? or what good would a package at the registry be?

davide125 commented 2 years ago

It makes packaging MM for Linux distros a bit easier (as they often have tooling for importing content from npm). I suspect some users might also end up installing MM from npm out of habit, as it's pretty common for node projects to use it.

rejas commented 2 years ago

well, up to @MichMich to publish a new version on npm. Not sure what he thinks...

rejas commented 1 year ago

@MichMich could you give some feedback to this issue?

MichMich commented 1 year ago

That's a good point. I want to limit the amount of ways to install MagicMirror, due to maintenance for the contributors. But if we can find a clean solution to install using npm or yarn, I'm all for it.

The issue we had back then. Is that you couldn't install it to a specific folder using npm. Not sure if that has changed.

rejas commented 1 year ago

I can run a npm i --prefix mm magicmirror without any problems. Not sure if that was the troublesome usecase but maybe @davide125 can weigh in on how he wants to install it (and maybe check if the current npm can isntall this old npm module)

davide125 commented 1 year ago

In my case I wanted to use npm as the source for packaging magicmirror in Fedora. The packaging tooling in Fedora is designed around pulling sources from npm. It's not mandatory (and I'm working around it at the moment), but it makes things much easier. If you're curious, https://bugzilla.redhat.com/show_bug.cgi?id=2103400 is where the packaging work is happening (that's at an old version for now because it still needs to pass review, I will update it to the latest before importing once it's approved and keep it up to date afterwards).

rejas commented 1 year ago

so can you check if the old version of mm install cleanly for your usecase? if so we can update the npm package to the latest version

davide125 commented 1 year ago

Yes, I just checked and it works fine for this. Thanks!

rejas commented 1 year ago

so might be worth updating the mm package in npm if there's no extra work needed ATM. No guaranteee for the future though, right @MichMich ?

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rejas commented 2 weeks ago

I still would like to update the npm registry with the newest version, maybe @MichMich can give me the rights there...

jimbo95-beep commented 2 weeks ago

Yes

On Sun, 6 Oct 2024, 14:30 Veeck, @.***> wrote:

I still would like to update the npm registry with the newest version, maybe @MichMich https://github.com/MichMich can give me the rights there...

— Reply to this email directly, view it on GitHub https://github.com/MagicMirrorOrg/MagicMirror/issues/2876#issuecomment-2395441361, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMBWX335EK6S72UQ2SJ7YLZ2E3PBAVCNFSM6AAAAABPNUXO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ2DCMZWGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>