MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.84k stars 4.21k forks source link

Module wather: Openweathermap: current and hourly show wrong temperature #2981

Closed Coernel82 closed 1 year ago

Coernel82 commented 1 year ago

Platform

let config = { //bla bla bla units: "metric", tempUnits: "metric", windUnits: "metric", modules :[ module: "weather", position: "top_right", config: { // using apiVersion: 3.0, results inst "loading..." units: "metric", tempUnits: "metric", windUnits: "metric", degreeLabel: true, appendLocationNameToHeader: false, weatherProvider: "openweathermap", type: "current", // same problem four "hourly" location: "Overath", locationID: "2855859", apiKey: "mysecretapi", weatherEndpoint: '/onecall', updateInterval: 6000000, animationSpeed: 0, decimalSymbol: ",", initialLoadDelay: 400, } }, { module: "weather", position: "top_right", config: { degreeLabel: true, appendLocationNameToHeader: false, weatherProvider: "openweathermap", type: "forecast", location: "Overath", locationID: "2855859", apiKey: "mysecretapi", weatherEndpoint: '/forecast', updateInterval: 6000000, animationSpeed: 0, decimalSymbol: ",", } }, // bla bla bla

sdetweil commented 1 year ago

from the doc, if /onecall is used as the endpoint lat and lon are required and location/locationid will not be used

Screenshot_20221224-065337_Chrome

Coernel82 commented 1 year ago

Can't believe I missed that though I have been reading the documentation thoroughly! However may I suggest that the information also is added in "General options --> type"? The way it is written now is as if in a cooking book there is a recipe for cake containing milk, butter and a pinch of salt. And then 20 pages later there in the glossary it says: sugar: please note that sugar is required for baking a cake.

sdetweil commented 1 year ago

well, weather is a kitchen sink kind of module, does 99,000 things

the general options apply to all providers formatting, display

but then the providers have specific parms., and some are interdependent as you've discovered.

and in your description I would have said 'sugar is required to bake THIS cake'

rejas commented 1 year ago

I am always happy about PRs in the documentation repo that clean things up :-)

Coernel82 commented 1 year ago

I will do so tomorrow, you will get your Pull Request!

Coernel82 commented 1 year ago

OK.... just had a look at this repository and I am stuck. Which repository do I have to fork to make a pull request for https://docs.magicmirror.builders/modules/weather.html

sdetweil commented 1 year ago

this repo https://github.com/MichMich/MagicMirror-Documentation

Coernel82 commented 1 year ago

Ok, and where is the specific file?

rejas commented 1 year ago

https://github.com/MichMich/MagicMirror-Documentation/blob/master/modules/weather.md

Coernel82 commented 1 year ago

Thank you. Will make a PR tonight or latest by tomorrow.

Coernel82 commented 1 year ago

weather.md updated. Problem solved.