search

MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.45k stars 4.16k forks source link

newsfeed enclosured picture feature #3447

Open bugsounet opened 1 month ago

bugsounet commented 1 month ago

Hi, i plan to add to newsfeed default module an enclosured picture of the item displayed.

What do you think about this feature?

sdetweil commented 1 month ago

more info.. enclosure picture of the item displayed

doesn't mean anything to me..

give examples.. does this mean it can't fit on the bottom_center anymore (too tall?)

bugsounet commented 1 month ago

The picture like this (example of one of my modules):

many feed have an enclosured picture related of article why not display it ?

sdetweil commented 1 month ago

ok, got it now.

I personally don't think the base should take on this kind of technical debt. That's what the 3rd party ecosystem is for. we give examples of what can be done in a functional way, we don't do every solution.

bugsounet commented 1 month ago

ok, it's just a proposal ;)

rejas commented 1 month ago

I wouldnt close it so fast, cause I like the idea. We always add new functionality to our code modules, so why not this? Maybe disable it per default, so the "slick" look is preserved.

bugsounet commented 1 month ago

@rejas: Ok, i will see