search

MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.83k stars 4.21k forks source link

Add wayland and windows start options #3594

Closed KristjanESPERANTO closed 4 weeks ago

KristjanESPERANTO commented 1 month ago

This PR adds start options for Wayland and Windows.

This would solve issue #3582.

To Do if this PR is merged:

KristjanESPERANTO commented 4 weeks ago

I dropped the attempt to add an windows installation option for this PR.

sdetweil commented 4 weeks ago

@KristjanESPERANTO if you used my shell js app it could be on install-mm

KristjanESPERANTO commented 4 weeks ago

@KristjanESPERANTO if you used my shell js app it could be on install-mm

I think it's good to handle this in different PRs. This one handles the start options and a new one could handle the installation.

khassel commented 4 weeks ago

btw tested this in VirtualBox

"install-mm:windows": "cmd /c npm install --ignore-scripts --no-audit --no-fund --no-update-notifier --only=prod --omit=dev && echo 'Installing vendor files ...' && cd vendor && npm install --loglevel=error --no-audit --no-fund --no-update-notifier && echo 'Installing fonts ...' && cd fonts && npm install --loglevel=error --no-audit --no-fund --no-update-notifier",`

and beside a small error (should be cd ../fonts) it worked :)

sdetweil commented 4 weeks ago

i think this could have been done together

my postinstall using my launcher 

"postinstall": "node js/es.js \"npm run install-vendor && npm run install-fonts && echo MagicMirror² installation finished successfully!\n\":npm run install-vendor & npm run install-fonts & echo MagicMirror² installation finished successfully!",

then we don't need multiple divergent commands.. (to document and support)

sdetweil commented 4 weeks ago

then we just use run mm-install if you ran install, then postinstall would be the same

sdetweil commented 4 weeks ago

we can do the same on start too..

js/es.js linux_command : windows_command

less confusing for our users..

KristjanESPERANTO commented 4 weeks ago

we can do the same on start too..

js/es.js linux_command : windows_command

We would need something like this: js/exec_script.js x11_command : wayland_command : windows_command.

less confusing for our users..

Yes, but different start options should not overwhelm a tinkerer. Also, when someone uses the additional commands, they should always be reminded that they are doing something that is not the default. This might help them to solve problems themselves and need less support.

Perhaps I will argue in a different direction in the future 😅. But I often have the thought that it might not be a good idea to make it too easy for our users (who are tinkerers). If we automate everything, they understand the system less and need more support. That's why I liked the decision that only the manual installation is the official one.