Open sdetweil opened 4 days ago
existiing code in calendar.js tests 2 things at the same time
if(showsEndOnlyWithDuration === true AND startdate===endate){
do nothing
} else{
add end display on
}
should be
if( startdate !== endate ){
if( showsEndOnlyWithDuration === true ){
add end display on
}
}
will fix and testcase for both conditions
SO.. fixing this causes a breaking change, as the setting was effectively ignored before, no testcase to test it
currently default is false.
fixing code breaks a few testcases.. generally shouldn't change testcases.. thats why they are there
change the default to true (same effective behavior as before fix) allows old testcases to continue
this exposes another issue.. we can't allow new config parms without at least 2 testcases.. with and without.. I don't know how we can enforce that in build
currently waiting
I think we live with the breaking change.. default is false.. I fixed the testcases...
using 2.29 test ics
shows end date/time, regardless of showsEndOnlyWithDuration setting