search

MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.83k stars 4.21k forks source link

feat(compliments): add configuration for refreshing remote file on interval #3608

Closed xsorifc28 closed 1 week ago

xsorifc28 commented 3 weeks ago

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that style issues are fixed.
  2. Don't forget to add an entry about your changes to the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly recommended that you update your branch of develop before creating a pull request to send us your changes. This makes everyone's lives easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

rejas commented 3 weeks ago

Thanks for your PR. Two things though:

sdetweil commented 3 weeks ago

more than likely a syntax error

node -c compliments.js

will check language syntax

sdetweil commented 1 week ago

I just pushed PR 3630 which does all and with testcases, using your code plus more

xsorifc28 commented 1 week ago

I just pushed PR 3630 which does all and with testcases, using your code plus more

Thank you much, apologies I have not been able to invest the time to ramp up on the project.

xsorifc28 commented 1 week ago

Closing in favor of #3630