MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.83k stars 4.21k forks source link

Bump croner from 8.1.2 to 9.0.0 in /vendor #3614

Closed dependabot[bot] closed 2 weeks ago

dependabot[bot] commented 3 weeks ago

Bumps croner from 8.1.2 to 9.0.0.

Release notes

Sourced from croner's releases.

9.0.0

Croner 9.0.0

This major release brings significant changes to Croner, improving consistency, fixing bugs, and modernizing the codebase.

Changes

  • Bug Fixes:

    • Fixed an issue where "every X seconds" crons would fail with a "maximum call stack exceeded" error (#260).
    • Fixed an issue where types were not supported when using ES module via jsr.io (#258).
  • API Changes:

    • The new keyword is now mandatory when instantiating Croner (e.g., new Cron(/* ... */)).
    • The default export has been removed. You now need to use import { Cron } from 'croner'; or const { Cron } = require('croner');.
  • File Structure Changes (relevant for direct file access):

    • All files in the /dist directory are now minified. croner.min.js has been renamed to croner.js.
    • Typings have been moved from /types to /dist.
    • Only the /src directory is exposed in the jsr module jsr.io/@​hexagon/croner.
  • Codebase Modernization:

    • The entire codebase has been migrated from JavaScript with JSDoc to TypeScript.
    • Deno is now used for formatting, type checking, and linting, resulting in a cleaner and more maintainable repository. Esbuild is used to build the npm module and typings.

Upgrade Notice:

Due to the API and file structure changes, upgrading from 8.x to 9.x may require modifications to your existing code. Please review the above changes carefully before migrating.

9.0.0-dev.12

  • Test new release workflow
Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
khassel commented 2 weeks ago

@sdetweil can you take a look (when back home)? New major version of croner causes failing tests, thanks.

sdetweil commented 2 weeks ago

ok, back at desk monday

sdetweil commented 2 weeks ago

breaking changes, push us back to 8 til then

IMG_0428

bugsounet commented 2 weeks ago

@dependabot rebase

dependabot[bot] commented 2 weeks ago

Sorry, only users with push access can use that command.

bugsounet commented 2 weeks ago

really :/

bugsounet commented 2 weeks ago

already in develop... you need to rebase

rejas commented 2 weeks ago

the lock file wasnt updated, so thats why this PR still existed...

sdetweil commented 2 weeks ago

i never update lock file as it is platform dependent and i mostly develop on amd64, and test on others