search

MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.84k stars 4.21k forks source link

Add spelling check to GitHub workflow #3623

Closed KristjanESPERANTO closed 3 weeks ago

KristjanESPERANTO commented 3 weeks ago

Besides updating cspell and handling spelling issues, the important change is adding the spelling check to the GitHub workflow.

I'm not sure if it will bother us too much when people create PRs. But I wanted to give it a try. Or do you have any other ideas on how we can run the spelling check on a regular basis?

sdetweil commented 3 weeks ago

i saw that the node-ical workflow added coderabbit which added a codeblock around an example i gave, and improved the text i added in doc

pretty impressive

khassel commented 3 weeks ago

Or do you have any other ideas on how we can run the spelling check on a regular basis?

maybe as cronjob as we have already in stale.yaml on develop?

KristjanESPERANTO commented 3 weeks ago

maybe as cronjob as we have already in stale.yaml on develop?

That sounds like a better approach! I added a GitHub workflow to run the spell check a few days before each release.

khassel commented 3 weeks ago

AFAIK the cronjobs needs to be on master wo work so we have to do the spellcheck manually before next release ...

KristjanESPERANTO commented 3 weeks ago

AFAIK the cronjobs needs to be on master

That would be suboptimal. Let's see what the job will do on 27th December :slightly_smiling_face: