search

MagicSketch / MagicMirror

The Sketch 3 Plugin for Perspective Transformation for Artboards
http://magicmirror.design
490 stars 39 forks source link

Sketch Mirror not supported by Sketch 3.8.1 #46

Open sagishrieber opened 8 years ago

sagishrieber commented 8 years ago

I have a file with some Sketch mirror objects in it, and it totally doesn't work after the update. I tried deleting all Sketch mirror objects - and now it works just fine. I can send the file for inspection if you would like.

jamztang commented 8 years ago

can you describe a bit more on what do you mean by doesn't work? And yes please send the file to my email, james@magicmirror.design, cheers

Kerchy commented 8 years ago

I have noticed the same issue with the latest update to sketch 3.8.2 (79753) The plugin no longer updates the existing artboards in my document even if I delete and relink the shape layer.

in addition the trouble shooting tips did not resolve the issue with the

  1. Try Reactivate Pro Version not displaying a dialogue and showing the user name James in the path to the plugin directory on my machine (there is no James profile on this machine) and
  2. Try Running Plugin in Safe Mode seemed to have no affect.
jamztang commented 8 years ago

Looks like the framework failed to load. What was the OS you're on and how did you install the plugin? @Kerchy

Kerchy commented 8 years ago

I am running OS X El Capitan version 10.11.4, sketch version 3.8.2 (29753). The version of Magic Mirror I tried to install is the latest 2.0.7 which I have tried to install via an update, deleting and installing via sketch toolbox and also via deleting and manually installation.

The plugin seems to install, giving me access from the plugins menu and the control panel however the art boards do not update when refreshed or changed manually

Kerchy commented 8 years ago

Update: Issue seems to be resolved now. Not sure if you have done any update @jamztang but the latest update to Sketch, Version 3.8.3 (29802), seemed to have a fix for the mirror functionality.

Kerchy commented 8 years ago

Update 2: Correction, the plugin seems to work on some screens but not all. Not sure if it doesn't respect the symbol I am using on the screen but it is not showing in the mirrored screen. Back to the drawing board

jamztang commented 8 years ago

@Kerchy can you send me your Sketch file and a screenshot to james@magicmirror.design so I can understand and investigate a bit more? Cheers

Kerchy commented 8 years ago

Hi James,

Unfortunately I can't share the sketch file as the project is under NDA.

I have done some investigation and think I've gotten to the bottom of the issue. It seem that the mirror has a problem when more than one artboard shares the same name. Although my artboards are the exact duplicates of the other the mirror doesn't seem to know which to mirror so seems not to update.

I have tested my theory by creating a duplicate of the screen and naming slightly differently to make it 100% unique, the mirroring now respects my selection.

Might be worth looking into this and adding it to your FAQ's as I'm sure I won't be the only person that runs into this issue. If it's already on there then apologies if I missed it.

I'll let you know if I have any other issues but hopefully this has sorted it for me

Thanks

On Tue, May 31, 2016 at 5:35 PM, James Tang notifications@github.com wrote:

@Kerchy https://github.com/Kerchy can you send me your Sketch file and a screenshot to james@magicmirror.design so I can understand and investigate a bit more? Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jamztang/MagicMirror/issues/46#issuecomment-222745570, or mute the thread https://github.com/notifications/unsubscribe/ASrlNNIQ_7u5PslKcaDw4ub_grqpESgfks5qHGNdgaJpZM4Ij-PB .

hpoul commented 8 years ago

I also have a problem that it is not working with sketch beta 39 - is this related?

i get the following output when i click "Refresh" within the magic mirror dialog.

01/07/16 08:20:28,272 Sketch Beta[523]: MagicMirror: -[MagicMirror refreshSelection] [Line 407] refresh selection
01/07/16 08:20:28,273 Sketch Beta[523]: MagicMirror: -[MMLayer refresh] [Line 163] ratio: 0.6770833333333334, quality: 0, perspective: 1
01/07/16 08:20:28,273 Sketch Beta[523]: MagicMirror: -[MMImageRenderer exportedImage] [Line 77] exporting image
01/07/16 08:20:28,273 Sketch Beta[523]: -[MSExportRequest setRootLayerID:]: unrecognized selector sent to instance 0x7ff5a8b4f170
01/07/16 08:20:28,274 Sketch Beta[523]: -[MSExportRequest setRootLayerID:]: unrecognized selector sent to instance 0x7ff5a8b4f170
01/07/16 08:20:28,276 Sketch Beta[523]: (
    0   CoreFoundation                      0x00007fff9975d4f2 __exceptionPreprocess + 178
    1   libobjc.A.dylib                     0x00007fff8e29373c objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff997c71ad -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   CoreFoundation                      0x00007fff996cd571 ___forwarding___ + 1009
    4   CoreFoundation                      0x00007fff996cd0f8 _CF_forwarding_prep_0 + 120
    5   MagicMirror                         0x000000011aa7805c -[MMImageRenderer exportedImage] + 460
    6   MagicMirror                         0x000000011aa735e4 -[MMLayer mirrorWithArtboard:imageQuality:colorSpaceIdentifier:perspective:] + 236
    7   MagicMirror                         0x000000011aa7ab6a -[MagicMirror mirrorLayer:fromArtboard:imageQuality:perspective:] + 155
    8   MagicMirror                         0x000000011aa739f7 -[MMLayer refresh] + 791
    9   MagicMirror                         0x000000011aa7abbd -[MagicMirror refreshLayer:] + 55
    10  MagicMirror                         0x000000011aa7bc22 __31-[MagicMirror refreshSelection]_block_invoke + 59
    11  CoreFoundation                      0x00007fff996d932d __53-[__NSArrayI enumerateObjectsWithOptions:usingBlock:]_block_invoke + 77
    12  CoreFoundation                      0x00007fff996d91f9 -[__NSArrayI enumerateObjectsWithOptions:usingBlock:] + 201
    13  MagicMirror                         0x000000011aa7bba1 -[MagicMirror refreshSelection] + 217
    14  MagicMirror                         0x000000011aa7f37d -[MMToolbarViewController refreshButtonDidPress:] + 48
    15  libsystem_trace.dylib               0x00007fff9a18107a _os_activity_initiate + 75
    16  AppKit                              0x00007fff95bbadbd -[NSApplication sendAction:to:from:] + 460
    17  AppKit                              0x00007fff95bccf12 -[NSControl sendAction:to:] + 86
    18  AppKit                              0x00007fff95bcce3c __26-[NSCell _sendActionFrom:]_block_invoke + 131
    19  libsystem_trace.dylib               0x00007fff9a18107a _os_activity_initiate + 75
    20  AppKit                              0x00007fff95bccd99 -[NSCell _sendActionFrom:] + 144
    21  libsystem_trace.dylib               0x00007fff9a18107a _os_activity_initiate + 75
    22  AppKit                              0x00007fff95bcb3be -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 2693
    23  AppKit                              0x00007fff95c13f04 -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 744
    24  AppKit                              0x00007fff95bc9ae8 -[NSControl mouseDown:] + 669
    25  AppKit                              0x00007fff95adb634 forwardMethod + 126
    26  AppKit                              0x00007fff9611e3c9 -[NSWindow _handleMouseDownEvent:isDelayedEvent:] + 6322
    27  AppKit                              0x00007fff9611f3ad -[NSWindow _reallySendEvent:isDelayedEvent:] + 212
    28  AppKit                              0x00007fff95b5e539 -[NSWindow sendEvent:] + 517
    29  AppKit                              0x00007fff95adea38 -[NSApplication sendEvent:] + 2540
    30  AppKit                              0x00007fff95945df2 -[NSApplication run] + 796
    31  AppKit                              0x00007fff9590f368 NSApplicationMain + 1176
    32  libdyld.dylib                       0x00007fff9e15f5ad start + 1
)
username1290 commented 8 years ago

I also get the unrecognized selector, I'm now using El Capitan:

All Messages.txt

jamztang commented 8 years ago

I am currently working on a fix on Sketch 3.9 beta. Please stay tuned and use 3.8 if possible

jamztang commented 8 years ago

Please try the latest version v2.0.9 that fixes Sketch 3.9 beta!

hpoul commented 8 years ago

looks good, seems to work again in 3.9 beta 👍 thanks!

username1290 commented 8 years ago

Hi, seems to be working again 👍 👍