search

MagicStack / Chromodynamics

Sublime Text & Atom color scheme.
Other
96 stars 7 forks source link

resolve deprecated selector #6

Closed reverbc closed 7 years ago

reverbc commented 7 years ago

Fix #5

1st1 commented 7 years ago

Thanks! Did you just regenerate atom schema using make?

reverbc commented 7 years ago

Uh no. I'm not that familiar with atom theme development (just started few minutes ago) so I manually merge the changes.

1st1 commented 7 years ago

Since atom scheme is autogenerated from the tmTheme file, we need to figure out how to update the Makefile. Otherwise, these changes will be lost next time we update the scheme.

reverbc commented 7 years ago

The regenerated less file has few differences with my hand-crafted one. I'll update that with this PR. Please hold.

reverbc commented 7 years ago

Hi @1st1 I've updated the theme and verified in my Atom. Could you help to check if it works on your environment too? Thanks.

1st1 commented 7 years ago

Is this a backwards compatible change btw? Will it work with Atom versions prior to v1.13.0?

elprans commented 7 years ago

It will not. package.json engines.atom will have to be updated (>=1.13.0)

reverbc commented 7 years ago

No it's not. Just downloaded 1.12.7 and it doesn't work. I've included that change as well.

1st1 commented 7 years ago

Thanks @reverbc!