Add typing to auxiliary classes around `Pool`

DanielNoord commented 3 weeks ago

In an effort to add more type annotations to common interfaces I decided to tackle some of the simpler methods. Also, to familiarise myself with the CI and project.

There is nothing groundbreaking in this PR. It:

Adds -> None for functions that are not returning anything
Expands one __aexit__ to be the correct full type
Types the arguments and attributes of PoolConnectionHolder, PoolConnectionProxyMeta and PoolAcquireContext based on actual usage patterns.

Let me know if there are any questions. I didn't really see any style checking recommendations in the documentation or setup.py so just used what black, ruff and others have decided is the de facto style of "modern" Python code.

DanielNoord commented 2 weeks ago

Removed the stringified annotations based on the review in https://github.com/MagicStack/asyncpg/pull/1198 as that seems to be the preferred style.

DanielNoord commented 1 week ago

@elprans Anything I can do to help get this merged? I don't want to spam you with pull requests but these are relatively trivial to make and there is still many more to make as well.

I'd like to find the most productive way to get these and other pull requests merged. For example, is there anybody else in the MagicStack team that can help review and merge these?

MagicStack / asyncpg

Add typing to auxiliary classes around `Pool` #1197