MagicStack / uvloop

Ultra fast asyncio event loop.
Apache License 2.0
10.27k stars 538 forks source link

Add support for loop.sock_sendto #561

Open difeid opened 1 year ago

difeid commented 1 year ago

The uvloop not implement method sock_sendto.

coroutine loop.sock_sendto(sock, data, address) Send a datagram from sock to address. Asynchronous version of socket.sendto()

Return the number of bytes sent. sock must be a non-blocking socket. New in version 3.11.

The simple test case that reproduces the problem:

#!/usr/bin/env python3

import socket
import asyncio
import uvloop

uvloop.install()

async def run():
    addr = ("127.0.0.1", 1111)
    s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
    s.setblocking(False)
    loop = asyncio.get_running_loop()
    await loop.sock_sendto(s, b'test', addr)

asyncio.run(run())

uvloop == 0.20.0 response:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.12/asyncio/runners.py", line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
  File "<stdin>", line 6, in run
  File "uvloop/loop.pyx", line 2629, in sock_sendto
NotImplementedError
WilliamOConnell commented 1 month ago

I had a similar issue with sock_recvfrom. It took me a while to figure out what was going on because I was using Sanic and hadn't actually heard of uvloop. I got around it by disabling it in the Sanic config but it would be nice if these methods could be implemented.

difeid commented 2 weeks ago

Yes, sock_recvfrom is also not implemented uvloop/loop.pyx

@cython.iterable_coroutine
async def sock_recvfrom(self, sock, bufsize):
    raise NotImplementedError

@cython.iterable_coroutine
async def sock_recvfrom_into(self, sock, buf, nbytes=0):
    raise NotImplementedError

@cython.iterable_coroutine
async def sock_sendto(self, sock, data, address):
    raise NotImplementedError