MagicTheGathering / mtg-sdk-go

Magic: The Gathering SDK - Go
MIT License
25 stars 17 forks source link

Planeswalker can now be retrieved correctly #1

Closed sharpner closed 7 years ago

sharpner commented 7 years ago

Loyalty was previously the wrong datatype

boombuler commented 7 years ago

Any Idea why the test fails?

boombuler commented 7 years ago

I'm merging this PR, because it doesn't break the build. Instead something seems to have broken the travis config. Because the master branch will not build either.

sharpner commented 7 years ago

thx locally the tests ran fine

boombuler commented 7 years ago

Same here...

Nino notifications@github.com schrieb am Mi., 19. Apr. 2017, 21:23:

thx locally the tests ran fine

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/MagicTheGathering/mtg-sdk-go/pull/1#issuecomment-295401358, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ050Q1Y1zPfVeUgFNAwe7DBpuCOez0ks5rxl9EgaJpZM4NCDj- .

sharpner commented 7 years ago

I looked into this and in my fork I used this travis.yml:

language: go
sudo: false
go:
  - 1.8
  - 1.7
script:
  - go test

So my guess would be a problem with tip of go.

Had to remove coveralls since I didn't wanna set it up for the fork, but it's possible that the wrapper script could also be the problem.

hope it helps.

boombuler commented 7 years ago

Thanks works fine!

sharpner commented 7 years ago

cool :)