search

MagicTheGathering / mtg-sdk-java

Magic: The Gathering SDK - Java
MIT License
71 stars 25 forks source link

Add card types to the foreign attributes #31

Open aleohnesTUBS opened 5 years ago

aleohnesTUBS commented 5 years ago

It would be great to have the name of the types for foreign languages.

This includes:

supertype type subtype types

Thanks in advance :)

thechucklingatom commented 5 years ago

I will look into this a bit more, but this doesn't look like it is supported by the MTGJson project, so it is unlikely that this data set exists anywhere by my current research. You can submit an enhancement request for MTGJson here. It would have to be added into the mtgio api for it to be supported in this SDK, but if the baseline data doesn't exist it probably wouldn't be supported.

JulesGoregues commented 1 year ago

The JSON seem to have a field named "type".

image

thechucklingatom commented 1 year ago

It does appear to now yes. I can look into adding this. I can't say for sure what it was like 5 years ago, but I can add something for what is there now