Implement foreign names for sets

MagicTheGathering / mtg-sdk-java

Magic: The Gathering SDK - Java

MIT License

69 stars 24 forks source link

Implement foreign names for sets #32

Open aleohnesTUBS opened 5 years ago

aleohnesTUBS commented 5 years ago

MtgSet currently does not support foreign names for the sets. This would be a nice addition.

Thank you in advance! :)

thechucklingatom commented 5 years ago

Unfortunately after doing some research it looks like set translations is not supported by the api that the sdk gets its data from. It is supported by the MTGJson project, so it should be trivial to add to the api. If you wouldn't mind submitting an issue here. Once it gets added we can link the issue and implement the required updates to support it here.

ZeldaZach commented 5 years ago

(Seems you sent them to the MTGJSON repo by mistake, but I'll make a note upstream)

thechucklingatom commented 5 years ago

Issue #31 is the issue I sent them to you for. They are also looking for foreign names for types, which I didn't see in the current documentation.