search

MagicTheGathering / mtg-sdk-javascript

Magic: The Gathering SDK - Javascript
MIT License
286 stars 62 forks source link

Fix flaky tests + Add Badges #4

Closed adback03 closed 8 years ago

adback03 commented 8 years ago

I synced this repo up with Travis-CI and noticed a test was no longer working due to data changes and the order in which data was being returned by the API. I fixed the test and also added the Discord + Travis-CI badges to the README.

I also removed the test and lib directories, since those get auto generated with npm run watch.

adback03 commented 8 years ago

I'm looking into this...Apparently Travis-CI actually expects the Test directory to be there.

raineorshine commented 8 years ago

Great, thanks!

I don't believe that we can remove the lib folder from the source unless we add an npm postinstall script to do the build. Otherwise the main entry point of the script will not be there when users install from npm:

"main": "./lib/index.js",

I have done projects both ways: either include the build output in the repo or add an npm postinstall script.

adback03 commented 8 years ago

Ohhh that makes sense. I must have ran npm install before I removed the folder. I'll get that back in.