search

MagicTheGathering / mtg-sdk-python

Magic: The Gathering SDK - Python
MIT License
255 stars 45 forks source link

Update tests for current api #28

Closed Reid-E closed 5 years ago

Reid-E commented 5 years ago

Several tests were failing because of what appear to be changes in the API's response.

The API returns an empty changelog Flavor text changed for a test card API now uses hyphen rather than emdash in type lines API updated card IDs, old ones no longer matched 'Host' is erroneously among Supertypes 'Hero' is erroneously among Types (creature subtype of Fraction Jackson) Some (but not all) Types from B.F.M. are included among the Types response 'Emblem' added to Types response 'khans' was too vague a search after the addition of "Khans of Tarkir Promos" Sets don't contain a "border" property at present Boosters return 14 cards

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-2.9%) to 94.853% when pulling 234663e7bff7e9e34cceb9c24f918c8c6b64e244 on Reid-E:update-tests-for-current-api into 3d28fe209d72356a559321355d3f7e53ca78a9cc on MagicTheGathering:master.

Reid-E commented 5 years ago

Coverage drop is because changelogs response is an empty list.

I don't think that code can get coverage if there is no data in the response.

adback03 commented 5 years ago

Thanks for the PR, could you refresh your branch from Master to resolve conflicts?

Reid-E commented 5 years ago

Alright, everything should be resolved now!