search

MagicTheGathering / mtg-sdk-python

Magic: The Gathering SDK - Python
MIT License
255 stars 45 forks source link

Cache #7

Closed bargulg closed 7 years ago

bargulg commented 7 years ago

Basic client-side cache for all requests. Configurable as DictCache, FileCache, or DummyCache

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-12.5%) to 85.874% when pulling 082d6662e581d46512e0ef06ea2ed124a8ada325 on bargulg:cache into ef825e30692250e1bf0ac372d81679fb6c2ec78f on MagicTheGathering:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-11.7%) to 86.617% when pulling 4f55956dbb2b4e721687133f6b68315d2c4e8511 on bargulg:cache into ef825e30692250e1bf0ac372d81679fb6c2ec78f on MagicTheGathering:master.

adback03 commented 7 years ago

Could you write some more tests for the caching logic? Coverage took a pretty big hit with the pull. Otherwise looks pretty good, I'll try pulling the code today or tomorrow and play around with it!

bargulg commented 7 years ago

I created a module for this cache here, because I used the same cache before, and it might be useful for other people: https://github.com/bargulg/multicache It's already in pip under name multicache. Currently I'm working on tests and docs for that multicache. If you don't mind the dependency too much, we could just use that module.