Magickbase / ckb-explorer-public-issues

CKB Explorer Issues
https://explorer.nervos.org/
3 stars 2 forks source link

The default image is missing when the image is displayed abnormally. #552

Open FrederLu opened 7 months ago

FrederLu commented 7 months ago
image image

Some pictures display abnormally under Activity and Inventory in Unique items, but the default pictures are missing.

https://ckb-explorer-frontend-in-magickbase-repo-n95m3z3oq-magickbase.vercel.app/nft-info/18717/36774863695284242987562314875030601135900841103382786420785039336730071084276

https://ckb-explorer-frontend-in-magickbase-repo-n95m3z3oq-magickbase.vercel.app/nft-info/18717/55898181095937060106134954979800952408608396490609853841701371717382113862182

Sven-TBD commented 5 months ago

Assigned this to @Daryl-L based on https://github.com/Magickbase/ckb-explorer-public-issues?tab=readme-ov-file#project-modules-and-responsible-persons. Please have a look at this and provide the estimated Start and end date.

Keith-CY commented 5 months ago

The image at https://ckb-explorer-frontend-in-magickbase-repo-n95m3z3oq-magickbase.vercel.app/nft-info/18717/55898181095937060106134954979800952408608396490609853841701371717382113862182 is

data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/PjwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL0dyYXBoaWNzL1NWRy8xLjEvRFREL3N2ZzExLmR0ZCI+PHN2ZyB0PSIxNzA2NjczMDA4MDE4IiBjbGFzcz0iaWNvbiIgdmlld0JveD0iMCAwIDEwMjQgMTAyNCIgdmVyc2lvbj0iMS4xIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHAtaWQ9IjM1MTEiIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCI+PHBhdGggZD0iTTUxMi4wNDUwMjUgOTYyLjg3NDg1MWMtMjQ4LjM0OTI1MSAwLTQ0OS42NTUwNy0yMDEuODQ2MTI0LTQ0OS42NTUwNy00NTAuOTE5ODc2IDAtMjQ4Ljk4NDcyNCAyMDEuMzA1ODE5LTQ1MC44MzA4NDkgNDQ5LjY1NTA3LTQ1MC44MzA4NDkgMjQ4LjI2MTI0NyAwIDQ0OS41NjUwMTkgMjAxLjg0NjEyNCA0NDkuNTY1MDE5IDQ1MC44MzA4NDlDOTYxLjYxMDA0NCA3NjEuMDI4NzI3IDc2MC4zMDYyNzIgOTYyLjg3NDg1MSA1MTIuMDQ1MDI1IDk2Mi44NzQ4NTFMNTEyLjA0NTAyNSA5NjIuODc0ODUxek01NzIuNzUxNjQyIDI4OS45MzMzNDVsLTY5LjIxMTMxNSAwYy05Ljc2NjQzNCAyNy4zMjIyNzUtMjcuNjg1NTQ5IDUxLjExNjE5MS01My44MzUxMTYgNzEuNjU0OTctMjYuMDU0Mzk5IDIwLjQ0NjY4MS01MC4zMDI2NjMgMzQuMjg4OTQ0LTcyLjU1NzUyNiA0MS42MTY4NGwwIDc3LjUzNTkxMWM0Mi4zNDY0NTctMTQuMDIzMzg4IDc5LjA3NzAxLTM1LjU1NTc5NyAxMTAuMTk3Nzk4LTY0Ljc3ODM1MmwwIDMyMi43MjAwNzYgODUuNDA2MTU5IDBMNTcyLjc1MTY0MiAyODkuOTMzMzQ1IDU3Mi43NTE2NDIgMjg5LjkzMzM0NXoiIGZpbGw9IiMyYzJjMmMiIHAtaWQ9IjM1MTIiPjwvcGF0aD48L3N2Zw==

which is valid but not properly rendered(try it on an online convertor at https://base64.guru/converter/decode/image/svg)

But this case cannot be detected by code, so I think it's fine to display the broken icon