search

Magickbase / ckb-explorer-public-issues

CKB Explorer Issues
https://explorer.nervos.org/
3 stars 2 forks source link

Set CORS head configurable #594

Open Keith-CY opened 7 months ago

Keith-CY commented 7 months ago

Now the CORS is configured at https://github.com/nervosnetwork/ckb-explorer/blob/8707dc618edcd0145bd88d821b16c87594612587/config/initializers/cors.rb#L20-L27 by hardcode(not sure if ENV[STAGING_DOMAIN] works as expected).

It's not reasonable because these domains should not be included in this project;

And it's not flexible, e.g. it's hard to limit some of the domains for mainnet while others for testnet/stagings only.

So here's the feature requested that the CORS domain list should be set in runtime instead of being hardcoded in the codebase.

Keith-CY commented 7 months ago

The following domains are expected to be listed for mainnet

And following are expected to be listed for testnet

zmcNotafraid commented 7 months ago

PR: https://github.com/nervosnetwork/ckb-explorer/pull/1727

Keith-CY commented 5 months ago

Add unidob.xyz for mainnet and testnet

zmcNotafraid commented 5 months ago

Add unidob.xyz for mainnet and testnet

Set already on testnet and mainnet

Keith-CY commented 5 months ago

Add https://test-long.metaforo.io/ for mainnet and testnet cc @zmcNotafraid

Keith-CY commented 5 months ago

Add https://test-long.metaforo.io/ for mainnet and testnet cc @zmcNotafraid

https://test-long.metaforo.io/ added

EthanYangHIT commented 5 months ago

add https://dev.utxoswap.xyz for testnet add https://utxoswap.xyz for testnet and mainnet cc @zmcNotafraid

zmcNotafraid commented 5 months ago

utxoswap.xyz All added.

EthanYangHIT commented 5 months ago

add https://testnet.utxoswap.xyz for testnet cc @zmcNotafraid

zmcNotafraid commented 5 months ago

add https://testnet.utxoswap.xyz for testnet cc @zmcNotafraid

Finished.

Keith-CY commented 5 months ago

Please add https://ckbeco.fund/ for mainnet

zmcNotafraid commented 5 months ago

https://ckbeco.fund/

Finished.

EthanYangHIT commented 4 months ago

add https://staging.utxoswap.xyz for mainnet

zmcNotafraid commented 4 months ago

add https://staging.utxoswap.xyz for mainnet

Added.

EthanYangHIT commented 4 months ago

add https://preview.utxoswap.xyz for mainnet

zmcNotafraid commented 4 months ago

https://preview.utxoswap.xyz

All utxoswap.syz subdomain can visit mainnet api

SpectreMercury commented 3 months ago

add https://ckb-mon.vercel.app/ for mainnet

Keith-CY commented 3 months ago

add ckb-mon.vercel.app for mainnet

Updated

Keith-CY commented 3 months ago

Add https://www.seal2earn.xyz for mainnet and testnet

nilevols commented 3 months ago

Pls add:

  1. world3-frontend-git-beta-matrix-group-global.vercel.app for testnet
  2. world3.ai for mainnet
Keith-CY commented 3 months ago

Pls add:

  1. world3-frontend-git-beta-matrix-group-global.vercel.app for testnet
  2. world3.ai for mainnet

Updated