`Done` button functionality is missing.

Magickbase / ckb-explorer-public-issues

CKB Explorer Issues

https://explorer.nervos.org/

3 stars 2 forks source link

`Done` button functionality is missing. #709

Closed FrederLu closed 2 months ago

FrederLu commented 3 months ago

https://github.com/Magickbase/ckb-explorer-public-issues/assets/25676576/fe084bb9-e517-4c7a-8d0e-49aa11c8a845

I found that the Done button does not work when selecting Language and Node. After making the corresponding selection, it will take effect without confirmation.

Sven-TBD commented 3 months ago

@PainterPuppets Hi Tao, Could you have a look at this when you are free.

PainterPuppets commented 3 months ago

It feels like switching states directly should be intuitive to use. Is this Done more like the close?

I'm not sure, can you decide on the exact interaction logic? @Sven-TBD

Sven-TBD commented 3 months ago

@PainterPuppets yes, we could just remove the "Done" button.

https://vs0cjf.axshare.com/?id=7um3d9&g=14

FrederLu commented 2 months ago

Verified.