Magickbase / ckb-explorer-public-issues

CKB Explorer Issues
https://explorer.nervos.org/
3 stars 2 forks source link

Support merging holders when export holders #717

Open Keith-CY opened 2 months ago

Keith-CY commented 2 months ago

This feature request comes from the community.


The xudt holder list can be exported at https://explorer.nervos.org/export-xudt-holders?id={xudt_type_hash}

Each CKB Adderss will be one entry in the list, but not every holder has only one CKB Address. When the holder uses a BTC Address, he/she main own various CKB Address due to RGB++ protocol.

That's why there's a column named owner.

Because each CKB Address is an independent line, the owner will be repeated if it has various CKB Address.

The community member wonders if there can be an option to merge these owners by removing the CKB Address column so that they can get the count of owners directly.

There are two basic solutions:

  1. Users can select which column should be included before the export and if the CKB Address is not selected, the Owner Address will be the basic index of the list;
  2. Provide a clear option that Merge owner address for this function.

Extra solution can be added.

rabbitz commented 1 month ago

PR: https://github.com/nervosnetwork/ckb-explorer/pull/2086 Readme: https://ckb-explorer.readme.io/reference/xudt-snapshot

Add the merge_with_owner parameter with a default value of false. When false, return the CKB Address column; when true, return the Owner column.

FrederLu commented 1 month ago

PR: nervosnetwork/ckb-explorer#2086 Readme: https://ckb-explorer.readme.io/reference/xudt-snapshot

Add the merge_with_owner parameter with a default value of false. When false, return the CKB Address column; when true, return the Owner column.

The API data has been verified. The front end needs to process merge_with_owner: true. Now the default is false to export CKB address information. @Sven-TBD

Kirl70 commented 1 month ago

Design Draft(12-4--12-8): https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=39141-49780&t=EnDccGZwxkTqaevy-1

image image
PainterPuppets commented 1 month ago

设计草稿(12-4--12-8): https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase ?node-id=39141-49780&t=EnDccGZwxkTqaevy-1 图像

图像

The xudt holder export only seems to support a specific block, so there should be no switch between date and block, as well as the backend is returning the csv data directly so i think it should be downloaded directly

FrederLu commented 1 month ago

Verified.