Magickbase / ckb-explorer-public-issues

CKB Explorer Issues
https://explorer.nervos.org/
3 stars 2 forks source link

xUDT List support displaying holders #795

Open Keith-CY opened 2 hours ago

Keith-CY commented 2 hours ago

Is your feature request related to a problem? Please describe. It's quite confusing for RGB++ users that there are unique ckb address and holder for an xUDT and they are different due to different data dimensions.

So the DevRel team suggests we provide the holder field on the list. However, it's indeed a concept of RGB++ but not of CKB. So it will not be displayed by default.

Describe the solution you'd like

Support the holder field but it's invisible by default. when visiting the URL includes a query view=rgbpp, the unique ckb address will be replaced by holder so all rgbpp products can lead users to the rgbpp view.

The technical updates are as follows:

  1. backend: add holder field in the xudt list response, which equals the one in the xudt detail response
  2. frontend: support view=rgbpp URL query, when matched, ckb unique address will be replaced by holder

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Keith-CY commented 2 hours ago

It's highly prioritized, so we'd better support it ASAP.

rabbitz commented 8 minutes ago

PR: https://github.com/nervosnetwork/ckb-explorer/pull/2286