Magickbase / godwoken_explorer

Godwoken Explorer
https://v1.gwscan.com
18 stars 9 forks source link

Issue 1356 2 #1396

Closed zmcNotafraid closed 1 year ago

zmcNotafraid commented 1 year ago

What problem does this PR solve?

Phoenix 1.7 remove view. So we need to adjust api to use new html component.

lib/hello_web
├── controllers
│   ├── hello_controller.ex
│   ├── hello_html.ex
│   ├── hello_html
|       ├── index.html.heex

Check List

Test

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2df96ae42aec66601ab8ab71b73b956a6f89e204-PR-1396


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/godwoken_explorer_web/controllers/admin/dashboard_controller.ex 0 1 0.0%
lib/godwoken_explorer_web/controllers/admin/job_controller.ex 0 2 0.0%
lib/godwoken_explorer_web/controllers/admin/smart_contract_html.ex 0 2 0.0%
lib/godwoken_explorer_web/controllers/admin/udt_html.ex 0 2 0.0%
lib/godwoken_explorer_web/controllers/api/error_json.ex 0 2 0.0%
lib/godwoken_explorer_web/controllers/api/fallback_controller.ex 1 3 33.33%
lib/godwoken_explorer_web/controllers/api/rpc/contract_json.ex 0 3 0.0%
lib/godwoken_explorer_web/controllers/admin/udt_controller.ex 0 9 0.0%
lib/godwoken_explorer_web/controllers/admin/smart_contract_controller.ex 0 11 0.0%
lib/godwoken_explorer_web/components/core_components.ex 0 168 0.0%
<!-- Total: 20 222 9.01% -->
Files with Coverage Reduction New Missed Lines %
lib/godwoken_explorer/address.ex 1 66.67%
lib/godwoken_explorer/application.ex 1 86.67%
lib/godwoken_indexer/server.ex 3 0%
lib/godwoken_indexer/fetcher/supervisor.ex 4 0%
lib/godwoken_indexer/block/supervisor.ex 10 0%
<!-- Total: 19 -->
Totals Coverage Status
Change from base Build a549a7cd5eb0c94b9deb5880e6c28c7eed505f1f: -1.5%
Covered Lines: 2934
Relevant Lines: 6267

💛 - Coveralls