Magickbase / godwoken_explorer

Godwoken Explorer
https://v1.gwscan.com
18 stars 8 forks source link

Issue 1465 #1467

Closed zmcNotafraid closed 1 year ago

zmcNotafraid commented 1 year ago

What problem does this PR solve?

When we fetch das indexer reverse info api, the account returns run.ckbees.bit,but account_alias returns ckbees#run.bit.So we save account as our bit alias.

Check List

Test

pull-request-quantifier-deprecated[bot] commented 1 year ago

This PR has 20 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Extra Small Size : +10 -10 Percentile : 8% Total files changed: 6 Change summary by file extension: .ex : +1 -1 .exs : +1 -1 .lock : +7 -7 .toml : +1 -1 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 8a759d90d86fa32bf60c32018196dac90b73a719-PR-1467


Files with Coverage Reduction New Missed Lines %
lib/godwoken_explorer/graphql/types/custom/bigint.ex 1 0%
lib/godwoken_explorer/graphql/types/custom/custom.ex 2 3.33%
lib/godwoken_explorer/chain/cache/address_bit_alias.ex 3 80.0%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 0284c01f683a2c24f608face89517b03322a5b90: -0.1%
Covered Lines: 3290
Relevant Lines: 5985

💛 - Coveralls