search

Magickbase / nervos-official-website

nervos.org
https://nervos-official-website.vercel.app/
3 stars 16 forks source link

"Categories" seems to be buggy #432

Open matt-nervos opened 7 months ago

matt-nervos commented 7 months ago

when clicking on a "Category" value, it takes a few seconds for the page to respond and the entries that are shown don't seem to correspond to the Category that was clicked

image image
WhiteMinds commented 7 months ago

when clicking on a "Category" value, it takes a few seconds for the page to respond

I can optimize this issue, but the URL will undergo some changes, transitioning from https://www.nervos.org/knowledge-base?sort_by=state&page=2 to https://www.nervos.org/knowledge-base/view/state/2.

the entries that are shown don't seem to correspond to the Category that was clicked

It looks like this feature is working fine here.

What exactly is incorrect? Do you want Popular Posts to be sorted by category based on clicks as well?

image

matt-nervos commented 7 months ago

thanks @Keith-CY is the URL change impact only cosmetic? I don't see any other effects, seems ok

Regarding the tag-click behavior, as a user, when I click the tag, I expect only articles related to that tag to show. Instead of "filter" it seems the behavior is "sort", so it shows articles related to the tag first, but then all other articles. This is confusing to a user, as they may think all of these articles are related to the tag they clicked

image
WhiteMinds commented 7 months ago

PR: https://github.com/Magickbase/nervos-official-website/pull/435

This PR changes the list page to static generation to improve access speed, and as a result, changes the URL format to /knowledge-base/list/$opts/$page.

Regarding the tag-click behavior, as a user, when I click the tag, I expect only articles related to that tag to show. Instead of "filter" it seems the behavior is "sort", so it shows articles related to the tag first, but then all other articles. This is confusing to a user, as they may think all of these articles are related to the tag they clicked

@matt-nervos Do we want to add an additional filtering feature?

If we directly replace the old sorting function with a filtering function, the functionality of sorting by Newest Post, Oldest Post will also be removed.

This requires PM involvement in the discussion, and if it is a new feature, we also need the designer to provide a design draft.