Magickbase / neuron-public-issues

Neuron Issues
4 stars 3 forks source link

Detect new upgrade on launch #139

Closed Keith-CY closed 9 months ago

Keith-CY commented 1 year ago

The detection of a new version to upgrade can be run on launch silently and prompt users to upgrade if possible.

This eager strategy acquaints users with new standards and functions timely.

Keith-CY commented 1 year ago

Please consider this feature as a priority.

Danie0918 commented 1 year ago

Considering the frequency of software updates and the effect of alerts, it would be a better solution for us to use pop-up alerts here.Note that for the current pop-up content it is recommended to use server-side configuration instead of getting the text in the github release so that users can get the core content of the release faster.

Requirement Contents:The style of the pop-up window can follow the design of the new UI 1.Automatically detects the version when opening Neuron Wallet and prompts the user to upgrade with a pop-up when a new version is available.(The detection limit needs to be set so as not to hog the performance of the user's device in the absence of network or service anomalies.) 2.When the user cancels the upgrade or closes the popup, it is logged locally and no longer pops up unless a new version is pushed. 3.The content of the upgrade instructions can be edited and pushed to the user on the server side, and the text of the corresponding language version is displayed according to the user's current language version.

new_page_1

Any other suggestions or questions about the above requirements? @Keith-CY @yanguoyu

yanguoyu commented 1 year ago

@Magickbase/developers

Keith-CY commented 1 year ago

Considering the frequency of software updates and the effect of alerts, it would be a better solution for us to use pop-up alerts here.Note that for the current pop-up content it is recommended to use server-side configuration instead of getting the text in the github release so that users can get the core content of the release faster.

Requirement Contents:The style of the pop-up window can follow the design of the new UI 1.Automatically detects the version when opening Neuron Wallet and prompts the user to upgrade with a pop-up when a new version is available.(The detection limit needs to be set so as not to hog the performance of the user's device in the absence of network or service anomalies.) 2.When the user cancels the upgrade or closes the popup, it is logged locally and no longer pops up unless a new version is pushed. 3.The content of the upgrade instructions can be edited and pushed to the user on the server side, and the text of the corresponding language version is displayed according to the user's current language version.

new_page_1

Any other suggestions or questions about the above requirements? @Keith-CY @yanguoyu

The excerpt can be distilled from the release note in a preconcerted format, so the server to push message can be avoided.

yanguoyu commented 1 year ago

Should we download it auto when finding a new version? Then if the user wants to update, they will not need to wait to download the version.

Danie0918 commented 1 year ago

Should we download it auto when finding a new version? Then if the user wants to update, they will not need to wait to download the version.

This is a sensitive operation, if the automatic download of updates usually requires the user to manually turn on.

yanguoyu commented 1 year ago

Should we download it auto when finding a new version? Then if the user wants to update, they will not need to wait to download the version.

This is a sensitive operation, if the automatic download of updates usually requires the user to manually turn on.

Only auto download, but the update action is still controlled by users.

Danie0918 commented 1 year ago

Considering the frequency of software updates and the effect of alerts, it would be a better solution for us to use pop-up alerts here.Note that for the current pop-up content it is recommended to use server-side configuration instead of getting the text in the github release so that users can get the core content of the release faster. Requirement Contents:The style of the pop-up window can follow the design of the new UI 1.Automatically detects the version when opening Neuron Wallet and prompts the user to upgrade with a pop-up when a new version is available.(The detection limit needs to be set so as not to hog the performance of the user's device in the absence of network or service anomalies.) 2.When the user cancels the upgrade or closes the popup, it is logged locally and no longer pops up unless a new version is pushed. 3.The content of the upgrade instructions can be edited and pushed to the user on the server side, and the text of the corresponding language version is displayed according to the user's current language version. new_page_1 Any other suggestions or questions about the above requirements? @Keith-CY @yanguoyu

The excerpt can be distilled from the release note in a preconcerted format, so the server to push message can be avoided.

This is also possible, so that we need to pay attention to the github release version of the text to be written in the general format, the pop-up window only need to get the summary part of the content.

Danie0918 commented 1 year ago

Should we download it auto when finding a new version? Then if the user wants to update, they will not need to wait to download the version.

It is better not to download automatically without the user's permission, this may be against the user's will and at the same time may make the user feel that the software is not secure.

Keith-CY commented 1 year ago

I've checked some applications and found the strategy of update is configurable

Pasted Graphic 19

It would be flexible.

Besides, a dialog informing users to upgrade is a bit brute, IMO. I would like a silent update badge on the screen, like the update to latest in the window of docker, or update telegram at the left bottom corner of Telegram. Just my personal opinion.

Keith-CY commented 1 year ago

Some other update check configuration image image image

Danie0918 commented 1 year ago

After thinking about it, I think adding upgrade pop-ups at software startup would indeed be a bit too forceful, and the software doesn't have a strong need for users to upgrade, but more of a need for users to spontaneously upgrade to get a better experience. I think it is not necessary to add automatic download and installation settings, because users still need to manually click on the upgrade and installation and need to be prompted by the pop-up window. Therefore, the following are the requirements after the update:

  1. Add a new version prompt to the settings in the left menu to detect when the software is launched.
  2. When the new version is prompted, users click Settings for the first time and the page slides to the General column.
  3. Add a new version version number prompt in the version bar, and a new version upgrade pop-up window appears when you click Check Update.
  4. The new version prompt of the settings in the left menu bar is not prompted after clicking on it, regardless of whether it is upgraded or not, and the software is saved locally until a different new version prompt is available.
  5. The new version prompt in the general section of the settings page, when not upgraded to a new version, need to always show.

Image

Keith-CY commented 1 year ago

After thinking about it, I think adding upgrade pop-ups at software startup would indeed be a bit too forceful, and the software doesn't have a strong need for users to upgrade, but more of a need for users to spontaneously upgrade to get a better experience. I think it is not necessary to add automatic download and installation settings, because users still need to manually click on the upgrade and installation and need to be prompted by the pop-up window. Therefore, the following are the requirements after the update:

  1. Add a new version prompt to the settings in the left menu to detect when the software is launched.
  2. When the new version is prompted, users click Settings for the first time and the page slides to the General column.
  3. Add a new version version number prompt in the version bar, and a new version upgrade pop-up window appears when you click Check Update.
  4. The new version prompt of the settings in the left menu bar is not prompted after clicking on it, regardless of whether it is upgraded or not, and the software is saved locally until a different new version prompt is available.
  5. The new version prompt in the general section of the settings page, when not upgraded to a new version, need to always show.

Image

LGTM, except image Will new version v0.112.0 and check for update show simultaneously?

Danie0918 commented 1 year ago

LGTM, except Will new version v0.112.0 and check for update show simultaneously?

It would be better to change here to upgrade now.So here you need to add another requirement, when there is a new version, check the upgrade strain upgrade now.

setting

Keith-CY commented 1 year ago

LGTM, except Will new version v0.112.0 and check for update show simultaneously?

It would be better to change here to upgrade now.So here you need to add another requirement, when there is a new version, check the upgrade strain upgrade now.

setting

👍

Keith-CY commented 1 year ago

Let's make the decision and go further

Danie0918 commented 1 year ago

@Kirl70 Please add the style of version update prompt based on the new version of Neuron UI.

https://github.com/Magickbase/neuron-public-issues/issues/139#issuecomment-1608587084

Kirl70 commented 1 year ago

I suggest simplifying the text for the updated version to maintain a consistent style.

image image

The specific update information will be displayed in a pop-up dialog:

image

If we add the version text, it will create a large blank space in the language selection box:

image
Danie0918 commented 1 year ago

I suggest simplifying the text for the updated version to maintain a consistent style. image image

Yes, it is possible.Note here that the version number shows the new version number to be updated.In addition, tips need to be added to the left-hand side menu bar again to help users discover new versions.

Kirl70 commented 1 year ago

The adjustment has been made to display the version number that can be updated when there is an update. A small red dot will appear on the left sidebar if there are updates. Additionally, I previously made notes on the display rules. Please review them to see if any adjustments or additions are needed. https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=1165%3A13586&mode=design&t=Y9gRzk3jlYfnm2sv-1

image
alexsupa597 commented 1 year ago

The adjustment has been made to display the version number that can be updated when there is an update. A small red dot will appear on the left sidebar if there are updates. Additionally, I previously made notes on the display rules. Please review them to see if any adjustments or additions are needed. https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=1165%3A13586&mode=design&t=Y9gRzk3jlYfnm2sv-1

@Kirl70 When we collapse the sidebar, how should it be displayed? Displaying the dot on the icon seems to conflict with the display when expanded.

image
Kirl70 commented 1 year ago

The adjustment has been made to display the version number that can be updated when there is an update. A small red dot will appear on the left sidebar if there are updates. Additionally, I previously made notes on the display rules. Please review them to see if any adjustments or additions are needed. https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=1165%3A13586&mode=design&t=Y9gRzk3jlYfnm2sv-1

@Kirl70 When we collapse the sidebar, how should it be displayed? Displaying the dot on the icon seems to conflict with the display when expanded.

image

The small red dot tips effect when collapsing the sidebar:

image
alexsupa597 commented 1 year ago

PR: https://github.com/nervosnetwork/neuron/pull/2769

alexsupa597 commented 1 year ago

@Kirl70 This font is Apple-specific. Please help to handle it.

image
Kirl70 commented 1 year ago

@Kirl70 This font is Apple-specific. Please help to handle it. image

Please use the default system font for regular text. Reference: https://github.com/Magickbase/visual-style-guide/issues/2#issuecomment-1233977778

yanguoyu commented 12 months ago

https://github.com/nervosnetwork/neuron/pull/2783

yanguoyu commented 12 months ago

@FrederLu https://github.com/nervosnetwork/neuron/pull/2783 is the PR for testing no update. https://github.com/nervosnetwork/neuron/pull/2787 is the PR for testing that has an update. https://github.com/nervosnetwork/neuron/pull/2788 is the PR for testing that has an update the next time.