Magickbase / neuron-public-issues

Neuron Issues
6 stars 3 forks source link

Highlight Visual C++ Redistribution along side with download link #271

Open Keith-CY opened 1 year ago

Keith-CY commented 1 year ago

Visual C++ Redistributable is required by CKB node as mentioned at https://docs.nervos.org/docs/basics/guides/ckb-on-windows/#download-from-releases and Neuron doesn't synchronize if it's not installed.

To ensure the vc_redist.x64.exe has been installed before starting, Neuron checks the windows system registry at https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/utils/redist-check.ts#L12-L16.

But the check does not 100% work, and users will be informed with an alert of https://github.com/nervosnetwork/neuron/blob/f7d28f2d1f5ad38581697cc621d35ca20073720e/packages/neuron-wallet/src/services/node.ts#L212. It's too technical for some users.

So I think a note of the vc_redist.x64.exe could be appended around the download link to inform users to install the dependency

yanguoyu commented 1 year ago

Does it mean if the check fails, users can also continue to use Neuron? Sometimes the check fails not cause by not installed but fails with the command. For example, https://github.com/Magickbase/neuron-public-issues/issues/134

Keith-CY commented 1 year ago

Does it mean if the check fails, users can also continue to use Neuron? Sometimes the check fails not cause by not installed but fails with the command. For example, #134

Yes, allow users to keep using Neuron even if the check fails.

There are 2 exceptions making check not 100% work

  1. vc_redist is installed, but it's not detected, so the alert shows
  2. vc_redist is not installed, but it's mistakenly detected, so the alert doesn't show

For case 1, both install vc_redist and ignore it work because vc_redist is actually installed. But the solution(https://github.com/Magickbase/neuron-public-issues/issues/134#issuecomment-1612387356) to fix detection can be appended in the note too.

For case 2, new users will be timely informed about the vc_redist on downloading Neuron once the note is added.

Danie0918 commented 4 months ago

Image

Kirl70 commented 4 months ago

Design Draft: https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=19033-39943&t=jSrokM1gUEZPpNxZ-1

image
yanguoyu commented 4 months ago

https://github.com/Magickbase/websites/pull/124