Magickbase / neuron-public-issues

Neuron Issues
6 stars 3 forks source link

Support locking window #318

Open Keith-CY opened 11 months ago

Keith-CY commented 11 months ago

This feature request comes from the community.


The case is that Neuron may be running on a communal computer of a group or friends while the owner wants to keep Neuron private. It's not feasible now because Neuron doesn't require authorization to access to balance/history.

So the feature required is that the window could be locked actively by the owner, and only unlock is allowed when the window is locked.


This feature is just an enhancement, but necessary or of high-priority.

Danie0918 commented 9 months ago

【Support locking window】

support_locking_window

Keith-CY commented 9 months ago

Maybe we can use the native dialog for unlocking image

BTW, will there be an independent password for unlocking? I think the security level should be different.


Update: Native dialog is not flexible enough for extension

Danie0918 commented 9 months ago

BTW, will there be an independent password for unlocking? I think the security level should be different.

Currently designed to be a universal password, an independent password could perhaps be introduced when there are more requirements. This is because an independent password means additional memorization and management.

yanguoyu commented 9 months ago

If someone restarts the Neuron wallet, does it should still locked if Neuron is locked before quitting?

Danie0918 commented 9 months ago

If someone restarts the Neuron wallet, does it should still locked if Neuron is locked before quitting?

Remains locked until it is unlocked.

Kirl70 commented 9 months ago

Design Draft: https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=32573%3A34064&mode=design&t=IxD3TGxHNfwwJORV-1

image
Keith-CY commented 9 months ago

I've found a detail that may be confusing

image

The menu item is lock window but the information is wallet is locked.

I think lock window and window is locked are clearer because lock wallet is a bit scary, and I would worry if the synchronization stops.


And as mentioned at https://github.com/Magickbase/neuron-public-issues/issues/318#issuecomment-1873679138, I'd suggest using an independent password for window unlocking because it's of a lower level of security. I would keep my wallet password used as little as possible.


Ah, I missed this message

Currently designed to be a universal password, an independent password could perhaps be introduced when there are more requirements. This is because an independent password means additional memorization and management.

The password to unlock window could be relatively simple, such as a PIN code, that doesn't require much memorization. Besides, the wallet can be backed up technically, so it won't block users if the PIN code is lost.

Danie0918 commented 9 months ago

Currently designed to be a universal password, an independent password could perhaps be introduced when there are more requirements. This is because an independent password means additional memorization and management.

The password to unlock window could be relatively simple, such as a PIN code, that doesn't require much memorization. Besides, the wallet can be backed up technically, so it won't block users if the PIN code is lost.

Does this mean that Neuron needs to add a PIN setup process or can Neuron use the system PIN?

Keith-CY commented 9 months ago

Currently designed to be a universal password, an independent password could perhaps be introduced when there are more requirements. This is because an independent password means additional memorization and management.

The password to unlock window could be relatively simple, such as a PIN code, that doesn't require much memorization. Besides, the wallet can be backed up technically, so it won't block users if the PIN code is lost.

Does this mean that Neuron needs to add a PIN setup process or can Neuron use the system PIN?

It might be impossible to get the system pin code. PIN code is just an example, the point is that users may use a simple code to protect the window, while using a complex password to protect the wallet.

Besides, when it's the hardware wallet, a user has to expose the password on the computer if the wallet password is used in this case.

Kirl70 commented 9 months ago

To make the page more dynamic, I suggest placing the password input box on the outer layer. Demo: Unlock

https://github.com/Magickbase/neuron-public-issues/assets/106060898/8f8a082e-4ab5-4dde-bb25-ea3090be234b

Wrong Password

https://github.com/Magickbase/neuron-public-issues/assets/106060898/7d9062d1-efea-4321-94af-6c27743a58d1

Mp4 animation resources: lock.zip

Danie0918 commented 9 months ago

drawing_unlock

To differentiate passwords and reduce the cost of memorization for the user, consider using a pattern password.

yanguoyu commented 9 months ago

why not add a four-number password to lock and unlock? Is it too complex to use pattern on the computer?

Keith-CY commented 9 months ago

why not add a four-number password to lock and unlock? Is it too complex to use pattern on the computer?

I agree that gesture pattern is too complex on a computer unless the screen is touchable.

Danie0918 commented 9 months ago

why not add a four-number password to lock and unlock? Is it too complex to use pattern on the computer?

I agree that gesture pattern is too complex on a computer unless the screen is touchable.

This only requires a long press on the mouse, though it may be a little harder with a trackpad.

For four-number password, it may create memory confusion with the original password, I'll think about it.

Danie0918 commented 9 months ago

pin

Kirl70 commented 9 months ago

Design Draft: https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=32573%3A34064&mode=design&t=ynLL7fvmguFtOzLw-1

image
yanguoyu commented 7 months ago

https://github.com/nervosnetwork/neuron/pull/3064