Magickbase / neuron-public-issues

Neuron Issues
6 stars 3 forks source link

Release Neuron@v0.114.3 #384

Closed Keith-CY closed 4 months ago

Keith-CY commented 5 months ago

A performance issue has been found in ckb light client@v0.3.6 which may lead to halted sync, and enormous logs.

This problem has been fixed in ckb light client@v0.3.7(https://github.com/nervosnetwork/ckb-light-client/releases/tag/v0.3.7) and the light client in Neuron has been upgraded by https://github.com/nervosnetwork/neuron/pull/3122

Almost all light client users will be impacted by this performance issue, so it's expected to be delivered ASAP.

The new release is ready at https://github.com/nervosnetwork/neuron/tree/rc/v0.114.3 please have a test @silySuper

Ref:

Keith-CY commented 5 months ago

How to reproduce:

This issue was caused by subscribe an empty script list to the light client.

Each time Neuron connects to the light client, Neuron will fetch the subscribed script list from it, then subscribe diff(subscribed script list, current script list). If all scripts have been subscribed before, an empty script list will be sent to the light client and the bug will be triggered.

So the following steps should lead to this case:

  1. generate a new wallet;
  2. switch to another wallet;
  3. switch back to the new wallet, an empty script list will be subscribed because the script list of the fresh wallet won't grow.
Keith-CY commented 4 months ago

Released at https://github.com/nervosnetwork/neuron/releases/tag/v0.114.3