Magickbase / neuron-public-issues

Neuron Issues
4 stars 3 forks source link

Remove `node-fetch` because `fetch` has been supported natively #409

Open Keith-CY opened 2 months ago

Keith-CY commented 2 months ago

This issue comes from https://github.com/Magickbase/neuron/pull/406

Fetch has been supported since Node.js@18 natively while Neuron uses Electron@30(https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/package.json#L96), delivered with Node.js@20, so the external module node-fetch can be removed.

Ref:

Keith-CY commented 1 month ago

My bad, the lib to remove is https://github.com/nodejs/undici, a temp lib before native node fetch is supported.

devchenyan commented 1 month ago

pr: https://github.com/nervosnetwork/neuron/pull/3213