Magickbase / neuron-public-issues

Neuron Issues
6 stars 3 forks source link

Exception on checking addresses #416

Open Keith-CY opened 4 months ago

Keith-CY commented 4 months ago

Describe the bug

352081456-feca6315-e0b4-4b31-bcb1-94249fc48e3b

Exception thrown in https://github.com/nervosnetwork/neuron/blob/master/packages/neuron-wallet/src/controllers/wallets.ts#L603

Expected behavior undefined address should be clearly handled

yanguoyu commented 4 months ago

@devchenyan Could you change this log to This is not an unlock dao transaction ${unlockhash}. Maybe No unlock transaction use ${unlockHash} as input will let the user confuse

devchenyan commented 4 months ago

https://github.com/nervosnetwork/neuron/pull/3216