MaginnGroup / Cassandra

Cassandra is a Monte Carlo package to conduct atomistic simulations.
https://cassandra.nd.edu/
GNU General Public License v3.0
41 stars 20 forks source link

High-energy CBMC dihedral trials incorrectly not flagged as overlap #133

Closed rwsmith7531 closed 1 year ago

rwsmith7531 commented 2 years ago

In the Fragment_Placement subroutine, nrg_kBT for a CBMC dihedral trial is compared against max_kBT. If nrg_kBT >= max_kBT, the trial weight is set to zero but overlap is not flagged for the trial. If all the trials have overlap (whether they are flagged as such or not), the first trial is chosen because the cumulative weight for trial 1 is zero, and Cassandra finds that prob_pick <= weight(1) because prob_pick also equals zero. For molecules with multiple fragments, this means that Build_Molecule can grow some molecules with overlap without flagging cbmc_overlap.