Module ID

[Atrate]

Hey there @gjf ,

I noticed an oversight. In the Submission Guidelines at https://github.com/Magisk-Modules-Alt-Repo/submission, it is stated that:

Module ID must match repo name (otherwise Magisk Manager fails to download it).

I have noticed that this is not the case for your module. Could you please fix that?

[gjf]

Fixed. Thank you.

[gjf]

@Atrate The issue is more complex than I thought. I have changed the module ID however it cannot be found in Fox's Mmm. At the same time some modules with "id - repo name" mismatch can be easily found: https://github.com/Magisk-Modules-Alt-Repo/Zeetaa-Tweaks and https://github.com/Magisk-Modules-Alt-Repo/magisk-module-koruri-font for instance. I have no idea what is wrong and it seems a repository error, not mine.

[Atrate]

@tytydraco Ideas?

[tytydraco]

Well it looks like your module is fine: https://github.com/Magisk-Modules-Alt-Repo/json/blob/main/modules.json#L5

It's found in the JSON, so your repo is live. Have you tried clearing the module cache in MM yet?

[gjf]

Well it looks like your module is fine: https://github.com/Magisk-Modules-Alt-Repo/json/blob/main/modules.json#L5

It's found in the JSON, so your repo is live. Have you tried clearing the module cache in MM yet?

I've cleaned a cache and module appears. Weird the app does not do it by itself when updating info. Now we have a new surprise:

Should I create zip by myself and place it somewhere? In original rep I shouldn't.

[tytydraco]

Very very strange here. Try zipping it anyway and checking. That will check if it's a repo issue or MM issue.

[gjf]

Very very strange here. Try zipping it anyway and checking. That will check if it's a repo issue or MM issue.

All right let's play. I have archived a repo content into zip. Here we go: AFWall-Boot-AntiLeak-main.zip

Now I open MM and try to download and install a module from repo. The same error as above.

Then I try to install an attached zip. No problem:

[tytydraco]

So that means magisk manager isn't downloading the zip properly. Let's try and see if maybe @Atrate can download it from MM. Is there any logs in the app that show the actual error?

[gjf]

So that means magisk manager isn't downloading the zip properly. Let's try and see if maybe @Atrate can download it from MM. Is there any logs in the app that show the actual error?

Frankly speaking I am new with MM. Actually I was even surprised zips are not downloaded at Download folder like original Magisk app did.

So if you tell me how to collect any specific logs - I will do.

[Fox2Code]

I will just wait for @tytydraco to close this issue directly, and wait for next json update before saying anything.

[tytydraco]

If the issue is fixed we can close. @gjf can you confirm? @Fox2Code made a commit that should fix the issue

[gjf]

If the issue is fixed we can close. @gjf can you confirm? @Fox2Code made a commit that should fix the issue

0.2.5 is still affected. So it looks like a commit was not integrated into the release yet.

[Fox2Code]

Should be fixed, it was a Magisk-Modules-Alt-Repo issue, I worked directly with @tytydraco to fix the issue.

[Fox2Code]

The issue is that the json generator was always using the "master" branch, it use the default repo branch now, so it's fixed now! Fixed there: https://github.com/Magisk-Modules-Alt-Repo/json/commit/b23cef53b6c494aca49f93ec98184aeb1a0ed61a