Magisk-Modules-Alt-Repo / HideNavBar

Fullscreen/Immersive Gesture Tweaks for Android 10-14
GNU General Public License v3.0
498 stars 21 forks source link

Full screen mode still leaves tiny white rectangles at the bottom #23

Closed pritster5 closed 2 years ago

pritster5 commented 2 years ago

Love this module but could you please fix those tiny white rectangles? Here's a picture of what I mean:

Screenshot_20221017-181021

DanGLES3 commented 2 years ago

Love this module but could you please fix those tiny white rectangles? Here's a picture of what I mean:

Screenshot_20221017-181021

If you're using the Gcam lag fix option that's just a common side effect because to fix the Gcam lag a fraction of the navigation bar needs to be visible

pritster5 commented 2 years ago

Actually I resolved the issue by hiding the navbar via an entirely different way: Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1

I haven't noticed any issues with the Gcam using this method to hide the navbar. (I'm using Vivid nav gestures for navigation)

DanGLES3 commented 2 years ago

Actually I resolved the issue by hiding the navbar via an entirely different way: Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1

I haven't noticed any issues with the Gcam using this method to hide the navbar. (I'm using Vivid nav gestures for navigation)

Tbh the issue with Gcam is slow mode switching, if that doesn't happen to you then with this method then great

pritster5 commented 2 years ago

Oh shit, I didn't know that's what was meant by Gcam issue. Yeah, I'm definitely experiencing lag with my method. Why does that happen?

DanGLES3 commented 2 years ago

Oh shit, I didn't know that's what was meant by Gcam issue. Yeah, I'm definitely experiencing lag with my method. Why does that happen?

Gcam (and Google's Markup/Screenshot editor) for whatever reason freak the f out if the navigation bar is not there (i legit have no clue why), only way to fix it is by keeping a fraction of the navigation bar still visible (with the Gcam fix)

pritster5 commented 2 years ago

Yeah it's really weird, because Snapchat and other camera apps work fine. Has the issue been reported to Google?

DanGLES3 commented 2 years ago

Yeah it's really weird, because Snapchat and other camera apps work fine. Has the issue been reported to Google?

Thing is, this issue only happens in a configuration (hiding the navbar) that simply doesn't exist on a stock pixel (as Gcam is only officially available there)

So i don't think Google would consider this a valid report as this only happens when you tamper/mod a Pixel device or use Gcam on a third party device (with this tweak) which Google doesn't support

pritster5 commented 2 years ago

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

DanGLES3 commented 2 years ago

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

None that I could find last time I've looked into it, for what's worth seems most people either don't notice or simply don't care about this issue enough to report/investigate it

I guess you could try reporting this to the developers of famous GCam mods to see if they can do anything at least on their modded APKs

DanGLES3 commented 2 years ago

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

As a workaround I could make a substratum theme to make those 3 lines disappear (i assume you're using 3 button navigation right?) by making an empty navigation bar layout, navbar would still exist but it would have no buttons

pritster5 commented 2 years ago

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

DanGLES3 commented 2 years ago

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

Best of luck to you, if you manage to get that fixed on GCam Mods be sure to notify me, I'd love to know that

DanGLES3 commented 2 years ago

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

Also tbh I'm already transitioning my module to substratum as it's just easier to maintain and way more reliable than my module could ever hope to be

Only reason why the module works so well now is because I'm using Android 12+ Fabricated Overlays feature however that limits what I can do to tweak the navigation bar (can't hide the buttons when the keyboard is opened for example) and that can't be applied to Android 10-11, not to mention it makes my module's installer even more messy than I'd like

pritster5 commented 2 years ago

Actually the thought just occurred to me, do the rectangles have to be white? Can they be transparent?

DanGLES3 commented 2 years ago

Actually the thought just occurred to me, do the rectangles have to be white? Can they be transparent?

Are you using 3 button navigation?

pritster5 commented 2 years ago

Yep

DanGLES3 commented 2 years ago

Yep

Then as i said previously i can make a substratum theme that creates a blank navigation bar layout without buttons, i'll need some time tho as i'm busy rn

pritster5 commented 2 years ago

Oh ok no rush. Thank you for taking the time to do this!

DanGLES3 commented 2 years ago

Oh ok no rush. Thank you for taking the time to do this!

app-release.zip

Here it is, use Substratum Lite btw, on the SystemUI option choose the hide keyboard buttons feature, see if it works out for you

Apologies for the long delay btw

pritster5 commented 2 years ago

Haha dude it's no worries at all, I was expecting something a few days from now, not a few hours.

Thanks so much! This is immensely helpful.

DanGLES3 commented 2 years ago

Haha dude it's no worries at all, I was expecting something a few days from now, not a few hours.

Thanks so much! This is immensely helpful.

Be sure to tell me if it works out for you

pritster5 commented 2 years ago

I'm on Android 13. Should I just get substratum lite off of the app store?

DanGLES3 commented 2 years ago

I'm on Android 13. Should I just get substratum lite off of the app store?

Yeah

pritster5 commented 2 years ago

Substratum Lite crashed a short while after I launched it and gave it root permission.

DanGLES3 commented 2 years ago

Substratum Lite crashed a short while after I launched it and gave it root permission.

Try clearing its data and see if it works, I've seen other people on Android 13 use it just fine

pritster5 commented 2 years ago

That fixed it. Do I have to uninstall your magisk module before testing this out?

DanGLES3 commented 2 years ago

That fixed it. Do I have to uninstall your magisk module before testing this out?

As long as you just enable the option in the System UI you should have no need to

pritster5 commented 2 years ago

Okay so unfortunately I uninstalled the Magisk module before using your substratum theme, but that's okay because the Android System portion behaves as expected with the nav bar mode set to "Fullscreen - GcamLagFix". However, even with the SystemUI set to "HidePill/Keyboard Buttons" I still see the three small white rectangles at the bottom.

DanGLES3 commented 2 years ago

Okay so unfortunately I uninstalled the Magisk module before using your substratum theme, but that's okay because the Android System portion behaves as expected with the nav bar mode set to "Fullscreen - GcamLagFix". However, even with the SystemUI set to "HidePill/Keyboard Buttons" I still see the three small white rectangles at the bottom.

Just to be sure, you've specifically chosen/installed the Hide Keyboard Buttons option right?

pritster5 commented 2 years ago

Yep, installed the Hide keyboard option, then I rebooted, then I enabled it and it had no effect.

pritster5 commented 2 years ago

FWIW, the SystemUI overlay name in Substratum is in Red, while the Android System one is green

DanGLES3 commented 2 years ago

FWIW, the SystemUI overlay name in Substratum is in Red, while the Android System one is green

If it's red it's because it's disabled

pritster5 commented 2 years ago

I see. However I found out that red means "disabled - invalid overlay" so I'm not even able to enable it.

Screenshot_20221021-044007 Screenshot_20221021-044001

pritster5 commented 2 years ago

Ignore the selections

DanGLES3 commented 2 years ago

Ignore the selections

Gimme a minute

DanGLES3 commented 2 years ago

Ignore the selections

app-release_src (1).zip

You'll have to uninstall the current APK, I'm not on my PC rn so i can't properly sign APKs

pritster5 commented 2 years ago

Still facing the same issue. I'm able to hide the navbar and buttons but not the rectangles. SystemUi overlay is still red/invalid

DanGLES3 commented 2 years ago

Still facing the same issue. I'm able to hide the navbar and buttons but not the rectangles. SystemUi overlay is still red/invalid

Did you reinstall the overlays and reboot?

pritster5 commented 2 years ago

Yep

DanGLES3 commented 2 years ago

Yep

Weird, overlays don't show as red here, when installing the system UI overlay, do any errors show up?

DanGLES3 commented 2 years ago

Yep

Btw i think i see the issue, you don't seem to be selecting anything in the system UI option (tap on it and explicitly choose the hide keyboard buttons option, the hidepill/keyboard buttons option is just description text, it's not an actual option)

Even the manage option just shows a blank system UI overlay with no description of it's option

pritster5 commented 2 years ago

Ahh I see. Ok so I set it to hide buttons and then rebooted and now everything is green. I enabled both, but I can still see the white rectangles.

DanGLES3 commented 2 years ago

Ahh I see. Ok so I set it to hide buttons and then rebooted and now everything is green. I enabled both, but I can still see the white rectangles.

Try the previous APK now, see if it works, if not I'll ask you for you to wait until tomorrow as it's now 6am and I'm severely exhausted rn

pritster5 commented 2 years ago

Oh jeez, yeah no need to get this done right now, please rest lol. I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

DanGLES3 commented 2 years ago

Oh jeez, yeah no need to get this done right now, please rest lol. I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

Yeah, gimme a sec, i've got a better solution just for ya, i'll need you to enable gesture navigation tho

i'll then make the theme disable the bottom gestures (to disable the back gestures just open the app from the app drawer and disable it from there, can't really do that within substratum), so you'll be able to use any other gesture app in its place

Is that good for you?

DanGLES3 commented 2 years ago

Oh jeez, yeah no need to get this done right now, please rest lol. I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

app-release.zip

You'll need to enable the no gestures option in the Android System (make sure to also install the fullscreen overlay on it)

pritster5 commented 2 years ago

Yes this would work. But hmm I don't see a "no gestures" option for Android System. I do see (and have disabled) the back gestures from within your APK.

pritster5 commented 2 years ago

Also would I use the "hide pill" option now for SystemUI?

DanGLES3 commented 2 years ago

Yes this would work. But hmm I don't see a "no gestures" option for Android System. I do see (and have disabled) the back gestures from within your APK.

Gimme a sec, guess I've sent the wrong apk

pritster5 commented 2 years ago

Also quick question: how do I reenable the back gesture after disabling it from within your app? I uninstalled your APK but forgot to turn it back on and now the left side of my screen can't back gesture, even after reboot.

Funnily enough, this actually fixed one of the reasons I didn't like the Pixel 7 Pro's gestures in the first place, which is that apps with a hamburger menu can't use the "swipe in from left to pull in the menu" gesture.