Magisk-Modules-Alt-Repo / HideNavBar

Fullscreen/Immersive Gesture Tweaks for Android 10-14
GNU General Public License v3.0
449 stars 20 forks source link

Disabling back gesture broken on OxygenOS 12 #25

Open ztNFny opened 1 year ago

ztNFny commented 1 year ago

On Oneplus 7 and 9 with Oxygen OS 12 disabling the back gesture doesn't work, neither left-only nor both.

Please let me know if you need any logs or apks.

DanGLES3 commented 1 year ago

On Oneplus 7 and 9 with Oxygen OS 12 disabling the back gesture doesn't work, neither left-only nor both.

Please let me know if youyou need any logs or apks.

On Oneplus 7 and 9 with Oxygen OS 12 disabling the back gesture doesn't work, neither left-only nor both.

Please let me know if you need any logs or apks.

I'll see what I can do, tho I suspect this might be because OOS 12 uses a custom back gesture implementation that isn't tied to any settings

DanGLES3 commented 9 months ago

On Oneplus 7 and 9 with Oxygen OS 12 disabling the back gesture doesn't work, neither left-only nor both.

Please let me know if you need any logs or apks.

Could you try again on the latest version?

M7MDE7EGAZY commented 7 months ago

doesn't work on realme gt 2 pro completely

M7MDE7EGAZY commented 7 months ago

android 14

DanGLES3 commented 7 months ago

doesn't work on realme gt 2 pro completely

Can guess why, ColorOS likely doesn't use the stock Android value for back gesture sensitivity, I'll have to look into the code of ColorOS to see if I can find anything

M7MDE7EGAZY commented 7 months ago

if you need anything i can send it

DanGLES3 commented 7 months ago

if you need anything i can send it

Systemui and framework apks would be nice

M7MDE7EGAZY commented 7 months ago

https://we.tl/t-g7EtJSEStO try this from latest a14 beta coloros

DanGLES3 commented 7 months ago

https://we.tl/t-g7EtJSEStO try this from latest a14 beta coloros

Thank you, I'll be sure to take a look today, apologies for the delay

M7MDE7EGAZY commented 7 months ago

Thanks a lot

M7MDE7EGAZY commented 7 months ago

are those the correct ones ?

DanGLES3 commented 7 months ago

are those the correct ones ?

Yes, tho it's hard to find what controls the back gesture sensitivity of ColorOS/Oxygen OS in any way that I could disable with Magisk

M7MDE7EGAZY commented 7 months ago

i use normal sensitivity but full screen is needed a lot the space under keyboard is irritating

M7MDE7EGAZY commented 7 months ago

still no hope ?

DanGLES3 commented 7 months ago

still no hope ?

Still haven't found any way to disable the back gestures of Color OS, I'm still looking into it but mostly seem like they hardcoded the way the back gesture works

M7MDE7EGAZY commented 7 months ago

what about full screen and removing that shitty space under keyboard ?

DanGLES3 commented 7 months ago

what about full screen and removing that shitty space under keyboard ?

Is that also broken on Color OS? If so I'll urgently take a look

M7MDE7EGAZY commented 7 months ago

yes just a sec i'll send ss

M7MDE7EGAZY commented 7 months ago

Screenshot_2023-12-20-01-46-35-66_6012fa4d4ddec268fc5c7112cbb265e7

M7MDE7EGAZY commented 7 months ago

image

DanGLES3 commented 7 months ago

Screenshot_2023-12-20-01-46-35-66_6012fa4d4ddec268fc5c7112cbb265e7

This space seems to come from Gboard's own spacing feature, have you tried using something like Rboard to reduce the bottom padding of the keyboard?

M7MDE7EGAZY commented 7 months ago

i used this module in cos 13.1 it was removed after choosing full screen but now like that

M7MDE7EGAZY commented 7 months ago

I'll try rboard

M7MDE7EGAZY commented 7 months ago

nothing worked even changing keyboard in rom completely

DanGLES3 commented 7 months ago

nothing worked even changing keyboard in rom completely

Just to be sure, you picked fullscreen and not immersive right? and no Gcam fix as well?

M7MDE7EGAZY commented 7 months ago

yes exactly

M7MDE7EGAZY commented 7 months ago

i never use gcam nor disable back gesture

DanGLES3 commented 7 months ago

yes exactly

Try the following command on a terminal app and see if it does anything, found it looking at the decompiled systemui code

su -c settings put secure hide_navigationbar_enable 1

DanGLES3 commented 7 months ago

i never use gcam nor disable back gesture

Also, does Color OS have its own immersive/hide gesture bar option? that might conflict with my module

M7MDE7EGAZY commented 7 months ago

Screenshot_2023-12-20-11-39-09-82_fc704e6b13c4fb26bf5e411f75da84f2 Screenshot_2023-12-20-11-39-02-04_fc704e6b13c4fb26bf5e411f75da84f2 Screenshot_2023-12-20-11-38-54-54_fc704e6b13c4fb26bf5e411f75da84f2

M7MDE7EGAZY commented 7 months ago

now after small update the command worked su -c settings put secure hide_navigationbar_enable 1

M7MDE7EGAZY commented 7 months ago

but now back gesture broken & in navigation it changed to buttons if i enabled gesture the space returns

M7MDE7EGAZY commented 7 months ago

https://github.com/Magisk-Modules-Alt-Repo/HideNavBar/assets/76889809/a7b89ca0-ca1f-4583-8cf4-7f925efc2d44

M7MDE7EGAZY commented 7 months ago

Immersion can be done, but I don't know why it doesn't work if you remove the bottom. The solution of removing the bottom works on Android14QPR, but it doesn't work on Color os14. My guess is that color replaces the bottom with dimen.