search

Magisk-Modules-Alt-Repo / HideNavBar

Fullscreen/Immersive Gesture Tweaks for Android 10-14
GNU General Public License v3.0
490 stars 21 forks source link

Pill is not hidden in tablet mode #38

Closed matejdro closed 11 months ago

matejdro commented 1 year ago

Steps to reproduce:

  1. Run adb shell wm density and note down original density so you can revert the change later
  2. Lower the density of your device enough to enter tablet mode (adb shell wm density 380 for Pixel 7 Pro, use higher number if necessary) - you will recognize tablet mode by constant taskbar at the bottom
  3. Hold your finger on any blank spot on the taskbar - it should turn into a pill
  4. Install HideNavBar module with Immersive (Without the Pill + Default Keyboard Spacing) config

Pill will still be visible.

DanGLES3 commented 12 months ago

Steps to reproduce:

  1. Run adb shell wm density and note down original density so you can revert the change later
  2. Lower the density of your device enough to enter tablet mode (adb shell wm density 380 for Pixel 7 Pro, use higher number if necessary) - you will recognize tablet mode by constant taskbar at the bottom
  3. Hold your finger on any blank spot on the taskbar - it should turn into a pill
  4. Install HideNavBar module with Immersive (Without the Pill + Default Keyboard Spacing) config

Pill will still be visible.

Check the latest versions

matejdro commented 12 months ago

Tried KSU-Test-3 with:

And issue persists. Pill is hidden in phone mode, but appears when transitioning to tablet mode.

DanGLES3 commented 12 months ago

Tried KSU-Test-3 with:

  • Immersive
  • Hide keyboard buttons
  • Reduce size of the keyboard bar
  • Low gesture sensitivity
  • No Gcam fix
  • Do NOT disable back gesture

And issue persists. Pill is hidden in phone mode, but appears when transitioning to tablet mode.

Send the Pixel 7 gesture overlays in /product/overlays and the framework APK in /system/framework and I'll work on it tomorrow morning

Also kindly attach a pic of how the navbar looks in tablet mode

matejdro commented 11 months ago

Thanks for looking into it.

Here is regular mode:

image

And here is tablet mode (I've disabled the taskbar to make it clearer):

image

Only difference between those images is the DPI. I've sent you the requested overlay files via Telegram, since they are quite big.