search

Magisk-Modules-Alt-Repo / NoStorageRestrict

Remove the restriction when selecting folders through SAF
192 stars 22 forks source link

Option/Guide to revert changes made by this module #8

Open Brian2po opened 1 year ago

Brian2po commented 1 year ago

So there might be errors that I encountered so I was hoping to revert the changes made but I don't see any way on how I can revert to default. Hoping to have a Guide on this.

DanGLES3 commented 1 year ago

Removing the module should undo the change made by the module as all it does is replace the externalstorageprovider APK

Brian2po commented 1 year ago

Removing the module should undo the change made by the module as all it does is replace the externalstorageprovider APK

I did do that but after checking the built-in file manager it shows this... Screenshot_2022-07-25-17-28-18-432_com google android documentsui Screenshot_2022-07-25-17-28-10-961_com google android documentsui Internal storage shows nothing (so when specifying download location from apps, it doesn't show internal location and sd is the only option that shows the whole SD card) I did research and did termux shared storage as a way to access internal storage but its a hassle. I hope you can help me about this problem.

DanGLES3 commented 1 year ago

Removing the module should undo the change made by the module as all it does is replace the externalstorageprovider APK

I did do that but after checking the built-in file manager it shows this... Screenshot_2022-07-25-17-28-18-432_com google android documentsui Screenshot_2022-07-25-17-28-10-961_com google android documentsui Internal storage shows nothing (so when specifying download location from apps, it doesn't show internal location and sd is the only option that shows the whole SD card) I did research and did termux shared storage as a way to access internal storage but its a hassle. I hope you can help me about this problem.

You can try this, use some app to extract the externalstorageprovider APK from your device and install it on top of the current one, see if that fixes the issue

Also apologies for the delay, today has been a bit busy

hawkraptor commented 1 year ago

I'm also experiencing issues that I'm fairly certain were caused by this module, except mine have caused issues with things such as taking video (through camera and built-in screen recorder) and with audio playback. No sounds at all from anywhere on the phone, and along with the camera errors some apps are failing to open with various file errors.

I have tried numerous methods of reverting the ExternalStorageProvider APK since reinstalling with the package manager only returned "app not installed". I tried using ADB to force an uninstall/reinstall and even repacked the module zip file with a stock version of the APK from a stock image dump. Short of a factory reset or reinstalling my rom and starting over, I'm not sure what else I can do.

Motorola One 5G Ace Android 11 LineageOS 18.1 lineage_kiev-userdebug 11 RQ3A.211001.001333026bf11

DanGLES3 commented 1 year ago

I'm also experiencing issues that I'm fairly certain were caused by this module, except mine have caused issues with things such as taking video (through camera and built-in screen recorder) and with audio playback. No sounds at all from anywhere on the phone, and along with the camera errors some apps are failing to open with various file errors.

I have tried numerous methods of reverting the ExternalStorageProvider APK since reinstalling with the package manager only returned "app not installed". I tried using ADB to force an uninstall/reinstall and even repacked the module zip file with a stock version of the APK from a stock image dump. Short of a factory reset or reinstalling my rom and starting over, I'm not sure what else I can do.

Motorola One 5G Ace Android 11 LineageOS 18.1 lineage_kiev-userdebug 11 RQ3A.211001.001333026bf11

I'mma be real with you, i don't understand how would modding the external storage provider could do any of this to your device short of some wonky Magisk/ROM bug

You may try clearing your dalvik cache

Either way, if you find a fix, I'd recommend the Xposed module version of this module to avoid any APK replacements potential shenanigans

hawkraptor commented 1 year ago

You're very likely right, digging through the filesystem stuff (I'm no expert but I run Linux at home) it doesn't seem like anything is obviously broken, so my guess is the issues were most likely related to something breaking in the audio system. I don't really know what could have caused that since I was not installing any audio-related modules, but I don't think this module was really to blame. It actually worked out of the box at first go and I could grant storage access to wherever I wanted using SAF. Once my backup is finished restoring I plan to give this mod another go since it seems way less invasive than the only other module I found to do this, which completely disables FUSE. I haven't successfully used any Xposed modules in the past but if I find more issues I'll give that a go. Cheers, and thanks for putting this module together!

DanGLES3 commented 1 year ago

You're very likely right, digging through the filesystem stuff (I'm no expert but I run Linux at home) it doesn't seem like anything is obviously broken, so my guess is the issues were most likely related to something breaking in the audio system. I don't really know what could have caused that since I was not installing any audio-related modules, but I don't think this module was really to blame. It actually worked out of the box at first go and I could grant storage access to wherever I wanted using SAF. Once my backup is finished restoring I plan to give this mod another go since it seems way less invasive than the only other module I found to do this, which completely disables FUSE. I haven't successfully used any Xposed modules in the past but if I find more issues I'll give that a go. Cheers, and thanks for putting this module together!

Wish you the best of luck, as for the Xposed module I've made it to be as compatible as possible since it directly patches just the necessary part of the code (instead of the whole APK, which could cause issues on some devices/ROMs possibly due to signature mismatches)

Also from experience, just disabling FUSE doesn't remove this restriction, I've still experienced it even with it off (which is why I've made this module)

hawkraptor commented 1 year ago

After a factory wipe and reinstall of LOS, I restored all my data and installed the standard module. Once again works out of the box and did not cause any audio/camera issues this time. I'm not sure if maybe there was an issue with the ROM going through ADB the first time, or maybe because this time around I'm using OpenGApps instead of BitGApps through Magisk. Either way, many thanks again for this module! Now I can manage my device files through KDE Connect in peace, just like I like to.

DanGLES3 commented 1 year ago

After a factory wipe and reinstall of LOS, I restored all my data and installed the standard module. Once again works out of the box and did not cause any audio/camera issues this time. I'm not sure if maybe there was an issue with the ROM going through ADB the first time, or maybe because this time around I'm using OpenGApps instead of BitGApps through Magisk. Either way, many thanks again for this module! Now I can manage my device files through KDE Connect in peace, just like I like to.

Always happy to help a fellow Linux/KDE user :)