search

Magisk-Modules-Alt-Repo / audio-misc-settings

A Magisk module for setting miscellaneous audio configuration values (media audio volume steps (100 steps), raising the resampling quality, disabling the effects framework, etc.)
GNU Affero General Public License v3.0
173 stars 12 forks source link

[FEATURE REQUEST] High Performance Mode for Qualcomm Dacs #18

Closed theduffster closed 6 months ago

theduffster commented 6 months ago

Hi, I just wanted to run this by you since you seem to be more on top of Android audio then anyone these days and was wondering if you were aware of High Performance Mode in Qualcomm Dacs. What do you think of this:

https://github.com/oiakera/high_perf_dac/issues/11#issuecomment-1779805058

Looking at the source code, the description "enable/disable class AB config for hph" definitely doesn't reveal much, so mysterious...

It looks like high performance mode enables these parameters:

WCD9XXX_CLSH_STATE_HPHR,
WCD9XXX_CLSH_REQ_ENABLE,
WCD9XXX_CLSH_EVENT_PRE_DAC)

I was hoping you may have some insight into what these parameters actually do, and what High Performance Mode actually does.

I'm also not sure if this works on newer phones, looking through newer phone source code I have yet to see "high_perf_mode" as an option in WCD9335+ phones. Still, Qualcomm says on their own website "High Performance Audio Playback" exists all the way up to the 9385.

yzyhk904 commented 6 months ago

I've tried such mods before, but felt no difference by them.

I think Qualcomm Dacs are excellent in default settings if audio-misc-settings, audio-jitter-silencer and DRC-remover module are applied.

theduffster commented 6 months ago

Thank you for the reply. So when you tried these mods, could you confirm they were actually working as intended? I'm curious if anyone has actually gotten high performance mode to activate on a newer dac.

It appears it used to be fairly robust, but I don't think anyone has been able to get it working on Qualcomm SOCs since the Snapdragon 820: https://github.com/PDesire/PDesireCoreKernel-Kitakami/blob/ce9f7c1111e227bee968304c682869c25ad5003f/Documentation/pdesireaudio/api.txt

yzyhk904 commented 6 months ago

I don't know they would work as intended or not, but just compared the hearable differences between before and after installing them. And I have a few interest for internal Dacs. Try external DACs and bluetooth devices.

Anyway I think jitter is crucial for audio experiences and analogue circuits are lesser important.