search

Magisk-Modules-Alt-Repo / chroot-distro

install linux distributions on android
GNU General Public License v3.0
69 stars 6 forks source link

Restore restores distro to wrong directory #11

Closed jjkola closed 1 month ago

jjkola commented 1 month ago

Steps to reproduce:

  1. Backup a distro
  2. Uninstall the distro
  3. Restore the distro

Expected outcome: Distro is restored properly

Actual outcome: Distro is restored to /data/local/chroot-distro/\<distroname>/data/local/chroot-distro/\<distroname>

jjkola commented 1 month ago

I have a fix ready in my fork (fix_backup_and_restore branch) for which I will create a PR after #7 has been merged. This fix also no longer mangles the restored backup by default. And you have to explicitly specify that you want to restore default settings.

MastaG commented 1 month ago

Perhaps you should just create a fork and create some action runner which pushes new releases on every commit :)

jjkola commented 1 month ago

This has been mostly scratching my own itch (I want to rescue a broken tablet to other uses) so I'm not entirely sure how much I will spend on this. But if there is enough interested I may take on this but before that I would like to see @YasserNull clarify the license (#12 ).

YasserNull commented 1 month ago

Thanks bro, I didn't notice

jjkola commented 1 month ago

Created a PR from the aforementioned branch.