search

Magisk-Modules-Alt-Repo / submission

Information regarding the submission of Magisk Modules to the Alt-Repo.
166 stars 8 forks source link

[Module] GoogleDNS4Magisk-IPv6 #206

Closed TukangM closed 9 months ago

TukangM commented 10 months ago

ID

GoogleDNS4Magisk-IPv6

Name

GoogleDNS4Magisk-IPv6

Description

Using the "Google DNS" DNS system-lessly! As simple as that and block ads and trackers.

Module repository link

https://github.com/TukangM/GoogleDNS4Magisk-IPv6

Source code link (for compiled binaries/APKs)

https://github.com/xerta555/CloudflareDNS4Magisk

Atrate commented 10 months ago
  1. Your update.json file should begin with a lowercase "u", not an uppercase "U".
  2. Your module.prop has incorrect values such as the Module ID, description, etc.
TukangM commented 10 months ago

Oh yes i forgot change the module.prop. i'll change later

TukangM commented 10 months ago

done

DerGoogler commented 10 months ago

@TukangM, if you want to hover your modules in MMRL, then you can include a mmrl.json file.

{
  "author": "TukangM",
  "contributors": ["xerta555"],
  "cover": "https://i.postimg.cc/gkhhPvjJ/google.png",
  "categories": [
    "Adblocking and Hosts Files",
    "Privacy Enhancements"
  ]
}

This file won't effect anything inside your module.

More you can read here

TukangM commented 10 months ago

@TukangM, if you want to hover your modules in MMRL, then you can include a mmrl.json file.

oh thank you for your advice. If I intend to add mrrl.json. I will add it in the future or right now

TukangM commented 10 months ago

DerGoogler/MMRL oh I understand. MMRL is an alternative to AMM. This is impressive. I will make mrrl.json right now in all my modules

DerGoogler commented 10 months ago

@TukangM, you have an typo. You wrote it mrrl.json but it should be mmrl.json

TukangM commented 10 months ago

done

Atrate commented 9 months ago

Seems you forgot to edit this to use Google's DNS (ipv4, as in the original module) https://github.com/TukangM/GoogleDNS4Magisk-IPv6/blob/01658bee97a37a940016f454158661ba3aeb1b64/post-fs-data.sh#L37

TukangM commented 9 months ago

fixed

Atrate commented 9 months ago

Approved.

I have created a repository for you at: https://github.com/Magisk-Modules-Alt-Repo/GoogleDNS4Magisk-IPv6 , enjoy!

Check your e-mail inbox for an invite to your new repository and remember to 'Watch' your repository on Github to have new issues in it show up in your feed.

Make sure to change your local repository's push URLs or configure 2 parallel push URLs.