[Module] Magisk Tailscaled

[anasfanani]

ID

magisk-tailscaled

Name

Magisk Tailscaled

Description

Magisk module for running Tailscale on rooted Android devices.

Module repository link

https://github.com/anasfanani/Magisk-Tailscaled

Source code link (for compiled binaries/APKs)

https://github.com/tailscale/tailscale

[anasfanani]

Please let me know what I missed, I'am still learning github & coding, also is my license valid ?

[DerGoogler]

License looks good to me.

customize.sh, line 11; why is the adb dir hard coded? customize.sh, line 24-26; unnecessary permission changes

I'm a new moderator, so @Atrate, or some other mod should overlook it

[anasfanani]

License looks good to me.

Thankyou

customize.sh, line 11; why is the adb dir hard coded?

Yeah I'm sorry this is my first time develop a magisk module, I copy from this example line 147;

I had to use unzip directly would call internal BusyBox applets.

customize.sh, line 24-26; unnecessary permission changes

I will remove this line asap.

Thankyou for your review.

[anasfanani]

Hello, I've recently updated my customize.sh file in this commit: https://github.com/anasfanani/Magisk-Tailscaled/commit/6c86fd1eb5de062892af535ad7402cc3be44f157.

Remove unnecessary permission changes.

To ensure that the binary files tailscale and tailscaled are executable. To achieve this, I've set the permissions for these binaries using the set_perm_recursive function with $F_TARGETDIR as the target directory, which is set to $MODPATH/system/bin.

Remove hard coded adb dir and use unzip directly.

And small typo fix for cleanup.

[DerGoogler]

To ensure that the binaries are executable:

set_perm $MODPATH/system/bin/tailscale 0 0 0755
set_perm $MODPATH/system/bin/tailscaled 0 0 0755

[anasfanani]

Apologize, why I should use two lines with hard coded binary name instead 1 line only should enough using set_perm_recursive functions. ?

set_perm_recursive <directory> <owner> <group> <dirpermission> <filepermission> [context]

[DerGoogler]

Apologize, why I should use two lines with hard coded binary name instead 1 line only should enough using set_perm_recursive functions. ?

set_perm_recursive <directory> <owner> <group> <dirpermission> <filepermission> [context]

$MODPATH/system/bin/tailscale isn't hard coded.

[anasfanani]

https://github.com/anasfanani/Magisk-Tailscaled/commit/a82ea30ba126b684d373d295b93031f72515a6c4

[anasfanani]

No update ?

[DerGoogler]

Hey @anasfanani, I haven't forgotten your submission, I'm currently enjoying the holidays with my friends and family.

I'll be available tomorrow again. ✌️

[anasfanani]

I have improve my module also, https://github.com/anasfanani/Magisk-Tailscaled/tree/dev

[DerGoogler]

Approved 👍.

I've created you a repo at https://github.com/Magisk-Modules-Alt-Repo/Magisk-Tailscaled. Please check if you received an repo invite.

Enjoy it, @anasfanani

[anasfanani]

Approved 👍.

I've created you a repo at https://github.com/Magisk-Modules-Alt-Repo/Magisk-Tailscaled. Please check if you received an repo invite.

Enjoy it, @anasfanani

Thankyou @DerGoogler

[anasfanani]

Hi @DerGoogler , can you assist me how to update the repo ?

[DerGoogler]

Hey @anasfanani,

I forgot to send you an invite back then. Please check your inbox if you have received an invite.

[anasfanani]

@DerGoogler Yea xD , I'm also confused why I cant manage my repo here, also for another repo please https://github.com/Magisk-Modules-Alt-Repo/magisk-autoboot

Thankyou verry much.

[DerGoogler]

Done